Merge pull request #13 from andybee/fix-http-regression

Fix http endpoint regression

Author: txase

index.js

@@ -66,7 +66,9 @@ class Client_AuroraDataMySQL extends Client_MySQL { // eslint-disable-line camel
       throw new Error(`Failed to load aws-sdk rdsdataservice client, did you forget to install it as a dependency? (${err.message})`);
     }
 
-    const https = require('https');
+    const https = this.config.connection.sdkConfig && String(this.config.connection.sdkConfig.endpoint).startsWith('http:')
+      ? require('http')
+      : require('https');
 
     const agent = new https.Agent({
       keepAlive: true

tests/test.js

@@ -101,6 +101,30 @@ describe('SDK configuration tests', () => {
       }
     });
   });
+
+  test('Uses HTTP agent when called with an HTTP endpoint', () => {
+    require('knex')({
+      client: require('..'),
+      connection: {
+        database: constants.DATABASE,
+        resourceArn: constants.AURORA_CLUSTER_ARN,
+        secretArn: constants.SECRET_ARN,
+        sdkConfig: {
+          endpoint: 'http://localhost:8080'
+        }
+      }
+    });
+
+    expect(RDSDataService).toHaveBeenCalledTimes(1);
+    expect(RDSDataService).toHaveBeenCalledWith({
+      endpoint: 'http://localhost:8080',
+      httpOptions: {
+        agent: expect.objectContaining({
+          protocol: 'http:'
+        })
+      }
+    });
+  });
 });
 
 test('Destroy functionality', async () => {