Do not delete task if task status is 20

Author: marickvantuil

src/CloudTasksJob.php

@@ -103,11 +103,31 @@ public function timeoutAt(): ?int
 
     public function delete(): void
     {
+        // Laravel automatically calls delete() after a job is processed successfully. However, this is
+        // not what we want to happen in Cloud Tasks because Cloud Tasks will also delete the task upon
+        // a 200 OK status, which means a task is deleted twice, possibly resulting in errors. So if the
+        // task was processed successfully (no errors or failures) then we will not delete the task
+        // manually and will let Cloud Tasks do it.
+        $successful =
+            // If the task has failed, we should be able to delete it permanently
+            $this->hasFailed() === false
+            // If the task has errored, it should be released, which in process deletes the errored task
+            && $this->hasError() === false;
+
+        if ($successful) {
+            return;
+        }
+
         parent::delete();
 
         $this->cloudTasksQueue->delete($this);
     }
 
+    public function hasError(): bool
+    {
+        return data_get($this->job, 'internal.errored') === true;
+    }
+
     public function release($delay = 0)
     {
         parent::release();

tests/QueueTest.php

@@ -242,7 +242,7 @@ public function jobs_can_be_released()
 
         // Assert
         Event::assertNotDispatched($this->getJobReleasedAfterExceptionEvent());
-        CloudTasksApi::assertDeletedTaskCount(1);
+        CloudTasksApi::assertDeletedTaskCount(0); // it returned 200 OK so we dont delete it, but Google does
         $releasedJob = null;
         Event::assertDispatched(JobReleased::class, function (JobReleased $event) use (&$releasedJob) {
             $releasedJob = $event->job;
@@ -257,7 +257,7 @@ public function jobs_can_be_released()
 
         $this->runFromPayload($releasedJob->getRawBody());
 
-        CloudTasksApi::assertDeletedTaskCount(2);
+        CloudTasksApi::assertDeletedTaskCount(0);
         CloudTasksApi::assertTaskCreated(function (Task $task) {
             $body = $task->getHttpRequest()->getBody();
             $decoded = json_decode($body, true);
@@ -476,6 +476,6 @@ public function test_ignoring_jobs_with_deleted_models()
 
         // Act
         Log::assertLogged('UserJob:John');
-        CloudTasksApi::assertTaskDeleted($job->task->getName());
+        CloudTasksApi::assertTaskNotDeleted($job->task->getName());
     }
 }