SecretFelt

[tdelabro]

We implemented zeroize on the Felt type.
But it seems to not be enough

As mentioned by @FilipLaurentiu here, because Felt also implements Copy and Clone and therefore is not guaranteed to be zeroed.

Issues were created in starknet-rs related to this:
xJonathanLEI/starknet-rs#667
xJonathanLEI/starknet-rs#735

@FilipLaurentiu seems to recommend using the secrecy crate instead (or in addition) to create a new SecretFelt type.

This discussion aims to weigh the different solutions offered to us and pick one.

[tdelabro]

@Trantorian1 @antiyro @0xLucqs @maciejka @gabrielbosio @AvivYossef-starkware

[0xLucqs]

If we want to use zeroise we need to remove Copy and Clone for the felt type or just copy ?

[tdelabro]

Copy is not the only vector of leak. Vec<Felt> reallocation (happens when pushing) could also leak it.
As well as other programming patterns.
The secrecy crates guarantee those patterns are not used

[0xLucqs]

sounds likes secrecy is the one we should use then ?

[tdelabro]

yup, that is what @FilipLaurentiu was suggesting.
He is willing to implement it if we all agree it is the way forward

[0xLucqs]

I don't think there's much to discuss if one works and the other doesn't let's go for the one that works ?

[tdelabro]

That is gospel to my ears!

[FilipLaurentiu]

I will start to work on the implementation of SecretFelt
An interesting article

[tdelabro]

Let's go @FilipLaurentiu

[FilipLaurentiu]

Implementation
I think I come up with a good implementation that will also have a similar API with the Felt type.