Warn when failed to migrate from placeholder

WithoutPants · WithoutPants · commit 33de28ce5d7f · 2022-10-20T01:18:32.000Z
diff --git a/pkg/sqlite/migrations/32_postmigrate.go b/pkg/sqlite/migrations/32_postmigrate.go
@@ -187,6 +187,10 @@ func (m *schema32Migrator) migrateFiles(ctx context.Context) error {
 					if err != nil {
 						return fmt.Errorf("migrating file %s: %w", p, err)
 					}
+				} else {
+					// if we don't reassign from the placeholder, it will fail
+					// so log a warning at least here
+					logger.Warnf("Unable to migrate invalid path: %s", p)
 				}
 
 				lastID = id

Original file line number	Diff line number	Diff line change
`@@ -187,6 +187,10 @@ func (m *schema32Migrator) migrateFiles(ctx context.Context) error {`
`187`	`187`	`if err != nil {`
`188`	`188`	`return fmt.Errorf("migrating file %s: %w", p, err)`
`189`	`189`	`}`
	`190`	`+ } else {`
	`191`	`+ // if we don't reassign from the placeholder, it will fail`
	`192`	`+ // so log a warning at least here`
	`193`	`+ logger.Warnf("Unable to migrate invalid path: %s", p)`
`190`	`194`	`}`
`191`	`195`
`192`	`196`	`lastID = id`