code cleanup

Author: flexatone

src/_arraykit.c

@@ -4373,7 +4373,7 @@ BIIterSeq_iter(BIIterSeqObject *self) {
 
 // Returns -1 on end of sequence; return -1 with exception set on
 static inline Py_ssize_t
-BIIterSeq_iternext_core(BIIterSeqObject *self)
+BIIterSeq_iternext_index(BIIterSeqObject *self)
 {
     Py_ssize_t i;
     if (self->reversed) {
@@ -4444,7 +4444,7 @@ BIIterSeq_iternext_core(BIIterSeqObject *self)
 static PyObject *
 BIIterSeq_iternext(BIIterSeqObject *self)
 {
-    Py_ssize_t i = BIIterSeq_iternext_core(self);
+    Py_ssize_t i = BIIterSeq_iternext_index(self);
     if (i == -1) {
         return NULL; // an error is set
     }
@@ -4502,7 +4502,6 @@ BIIterSlice_dealloc(BIIterSliceObject *self) {
     Py_DECREF((PyObject*)self->bi);
     Py_DECREF(self->selector);
     PyObject_Del((PyObject*)self);
-    // Py_TYPE(self)->tp_free((PyObject *)self);
 }
 
 static PyObject*
@@ -4513,7 +4512,7 @@ BIIterSlice_iter(BIIterSliceObject *self) {
 
 // NOTE: this does not use `reversed`, as pos, step, and count are set in BIIterSelector_new
 static inline Py_ssize_t
-BIIterSlice_iternext_core(BIIterSliceObject *self)
+BIIterSlice_iternext_index(BIIterSliceObject *self)
 {
     if (self->len == 0 || self->count >= self->len) {
         return -1;
@@ -4527,7 +4526,7 @@ BIIterSlice_iternext_core(BIIterSliceObject *self)
 
 static PyObject *
 BIIterSlice_iternext(BIIterSliceObject *self) {
-    Py_ssize_t i = BIIterSlice_iternext_core(self);
+    Py_ssize_t i = BIIterSlice_iternext_index(self);
     if (i == -1) {
         return NULL;
     }
@@ -4591,7 +4590,7 @@ BIIterBoolean_iter(BIIterBooleanObject *self)
 }
 
 static inline Py_ssize_t
-BIIterBoolean_iternext_core(BIIterBooleanObject *self)
+BIIterBoolean_iternext_index(BIIterBooleanObject *self)
 {
     npy_bool v = 0;
     Py_ssize_t i = -1;
@@ -4627,7 +4626,7 @@ BIIterBoolean_iternext_core(BIIterBooleanObject *self)
 
 static PyObject *
 BIIterBoolean_iternext(BIIterBooleanObject *self) {
-    Py_ssize_t i = BIIterBoolean_iternext_core(self);
+    Py_ssize_t i = BIIterBoolean_iternext_index(self);
     if (i == -1) {
         return NULL;
     }
@@ -4775,13 +4774,13 @@ BIIterContiguous_iternext(BIIterContiguousObject *self)
             self->next_block = self->next_column = -1; // clear next state
         }
         if (type == &BIIterSeqType) {
-            i = BIIterSeq_iternext_core((BIIterSeqObject*)iter);
+            i = BIIterSeq_iternext_index((BIIterSeqObject*)iter);
         }
         else if (type == &BIIterSliceType) {
-            i = BIIterSlice_iternext_core((BIIterSliceObject*)iter);
+            i = BIIterSlice_iternext_index((BIIterSliceObject*)iter);
         }
         else if (type == &BIIterBoolType) {
-            i = BIIterBoolean_iternext_core((BIIterBooleanObject*)iter);
+            i = BIIterBoolean_iternext_index((BIIterBooleanObject*)iter);
         }
         if (i == -1) { // end of iteration or error
             if (PyErr_Occurred()) {
@@ -4795,7 +4794,7 @@ BIIterContiguous_iternext(BIIterContiguousObject *self)
                             self->last_column,
                             self->reduce));
         }
-        // i is gauranteed to be within the range of self->bit_count at this point; the only source of arbitrary indices is in BIIterSeq_iternext_core, and that function validates the range
+        // i is gauranteed to be within the range of self->bit_count at this point; the only source of arbitrary indices is in BIIterSeq_iternext_index, and that function validates the range
         BlockIndexRecord* biri = &self->bi->bir[i];
         block = biri->block;
         column = biri->column;
@@ -5063,8 +5062,6 @@ BlockIndex_new(PyTypeObject *cls, PyObject *args, PyObject *kwargs) {
 // Returns 0 on success, -1 on error.
 int
 BlockIndex_init(PyObject *self, PyObject *args, PyObject *kwargs) {
-    // PyTypeObject* cls = Py_TYPE(self); // borrowed ref
-    // const char *name = cls->tp_name;
     BlockIndexObject* bi = (BlockIndexObject*)self;
 
     Py_ssize_t block_count = 0;