refactor: use base constructor and remove unreachable branch

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: kgryte

lib/node_modules/@stdlib/ndarray/flatten-from/lib/main.js

@@ -34,8 +34,8 @@ var shape2strides = require( '@stdlib/ndarray/base/shape2strides' );
 var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 var flattenShapeFrom = require( '@stdlib/ndarray/base/flatten-shape-from' );
 var assign = require( '@stdlib/ndarray/base/assign' );
+var ndarray = require( '@stdlib/ndarray/base/ctor' );
 var emptyLike = require( '@stdlib/ndarray/empty-like' );
-var ndarray = require( '@stdlib/ndarray/ctor' );
 var format = require( '@stdlib/string/format' );
 
 
@@ -285,7 +285,6 @@ function flattenFrom( x, dim, options ) {
 	var view;
 	var opts;
 	var xsh;
-	var st;
 	var o;
 	var y;
 
@@ -347,8 +346,7 @@ function flattenFrom( x, dim, options ) {
 	});
 
 	// Create a view on top of the output ndarray having the same shape as the input ndarray:
-	st = ( xsh.length > 0 ) ? shape2strides( xsh, opts.order ) : [ 0 ];
-	view = ndarray( opts.dtype, getData( y ), xsh, st, 0, opts.order );
+	view = new ndarray( opts.dtype, getData( y ), xsh, shape2strides( xsh, opts.order ), 0, opts.order ); // eslint-disable-line max-len
 
 	// Copy elements to the output ndarray:
 	assign( [ x, view ] );