phpstan executed for each Symfony version

Author: steevanb

.github/workflows/ci.yml

@@ -12,10 +12,11 @@ jobs:
         strategy:
             matrix:
                 php: [--php=8.1, --php=8.2]
+                symfony: [--symfony=6.1, --symfony=6.2, --symfony=6.3]
         steps:
             - uses: actions/checkout@v2
             - uses: ./.github/actions/ci-env
-            - run: bin/ci/phpstan ${{ matrix.php }}
+            - run: bin/ci/phpstan ${{ matrix.php }} ${{ matrix.symfony }}
 
     phpdd:
         runs-on: ubuntu-latest
@@ -60,7 +61,7 @@ jobs:
         strategy:
             matrix:
                 php: [--php=8.1, --php=8.2]
-                symfony: [--symfony=6.1, --symfony=6.2]
+                symfony: [--symfony=6.1, --symfony=6.2, --symfony=6.3]
         steps:
             - uses: actions/checkout@v2
             - uses: ./.github/actions/ci-env

bin/ci/phpstan

@@ -7,11 +7,14 @@ readonly ROOT_DIR="$(realpath "$(dirname "$(realpath "$0")")/../..")"
 source "${ROOT_DIR}"/bin/ci/dockerise.inc.bash
 
 phpVersion=
+symfonyVersion=
 phpstanParameters=
 clearCache=false
 for arg in "${@}"; do
     if [ "${arg:0:6}" == "--php=" ]; then
         phpVersion="${arg:6}"
+    elif [ "${arg:0:10}" == "--symfony=" ]; then
+        symfonyVersion="${arg:10}"
     elif [ "${arg}" == "--clear-cache" ]; then
         clearCache=true
     else
@@ -24,15 +27,15 @@ if [ "${clearCache}" == true ] && [ -d "${ROOT_DIR}"/var/ci/phpstan ]; then
     rm -rf "${ROOT_DIR}"/var/ci/phpstan
 fi
 
-if [ "${phpVersion}" == "" ]; then
+if [ "${phpVersion}" == "" ] || [ "${symfonyVersion}" == "" ]; then
     php8.1 "${ROOT_DIR}"/bin/ci/phpstan.php ${phpstanParameters}
 else
-    echo "PHP ${phpVersion}"
+    echo "PHP ${phpVersion} - Symfony ${symfonyVersion}"
 
     "php${phpVersion}" \
         "${PHPSTAN_BIN_PATH}" \
             analyse \
                 --ansi \
-                --configuration config/ci/phpstan.php-"${phpVersion}".neon \
+                --configuration config/ci/phpstan.php-"${phpVersion}".symfony-"${symfonyVersion}".neon \
                 ${phpstanParameters}
 fi

bin/ci/phpstan.php

@@ -10,27 +10,55 @@
 use Steevanb\PhpTypedArray\ScalarArray\StringArray;
 use Symfony\Component\Console\Input\ArgvInput;
 
-require $_SERVER['COMPOSER_HOME'] . '/vendor/autoload.php';
 require dirname(__DIR__, 2) . '/vendor/autoload.php';
 
-function createPhpstanProcesses(): ProcessInterfaceArray
+function getAvailableSymfonyVersions(): StringArray
 {
-    $phpVersions = new StringArray(['8.1', '8.2']);
+    $return = new StringArray();
+    foreach (new StringArray(['6.1', '6.2', '6.3']) as $symfonyVersion) {
+        $return[] = $symfonyVersion;
+    }
+
+    return $return;
+}
+
+function createPhpstanProcesses(string $phpVersion = null, string $symfonyVersion = null): ProcessInterfaceArray
+{
+    $phpVersions = new StringArray(is_string($phpVersion) ? [$phpVersion] : ['8.1', '8.2']);
 
     $return = new ProcessInterfaceArray();
     foreach ($phpVersions as $loopPhpVersion) {
-        $return[] = createPhpstanProcess($loopPhpVersion);
+        $symfonyVersions = is_string($symfonyVersion)
+            ? [$symfonyVersion]
+            : getAvailableSymfonyVersions()->toArray();
+
+        foreach ($symfonyVersions as $loopSymfonyVersion) {
+            $return[] = createPhpstanProcess($loopPhpVersion, $loopSymfonyVersion);
+        }
     }
 
     return $return;
 }
 
-function createPhpstanProcess(string $phpVersion): Process
+function createPhpstanProcess(string $phpVersion, string $symfonyVersion): Process
 {
-    return (new Process([__DIR__ . '/phpstan', '--php=' . $phpVersion]))
-        ->setName('phpstan --php=' . $phpVersion);
+    return (new Process([__DIR__ . '/phpstan', '--php=' . $phpVersion, '--symfony=' . $symfonyVersion]))
+        ->setName('phpstan --php=' . $phpVersion . ' --symfony=' . $symfonyVersion);
+}
+
+$phpVersion = null;
+$symfonyVersion = null;
+$applicationArgv = new StringArray();
+foreach ($argv as $arg) {
+    if (str_starts_with($arg, '--php=')) {
+        $phpVersion = substr($arg, 6);
+    } elseif (str_starts_with($arg, '--symfony=')) {
+        $symfonyVersion = substr($arg, 10);
+    } else {
+        $applicationArgv[] = $arg;
+    }
 }
 
 (new ParallelProcessesApplication())
-    ->addProcesses(createPhpstanProcesses())
-    ->run(new ArgvInput($argv));
+    ->addProcesses(createPhpstanProcesses($phpVersion, $symfonyVersion))
+    ->run(new ArgvInput($applicationArgv->toArray()));

bin/ci/phpunit.php

@@ -15,7 +15,7 @@
 function getAvailableSymfonyVersions(): StringArray
 {
     $return = new StringArray();
-    foreach (new StringArray(['6.1', '6.2']) as $symfonyVersion) {
+    foreach (new StringArray(['6.1', '6.2', '6.3']) as $symfonyVersion) {
         $return[] = $symfonyVersion;
     }
 

changelog.md

@@ -1,5 +1,9 @@
 ### master
 
+- [#227](https://github.com/steevanb/php-parallel-processes/issues/227) Fix TearDownProcess who never start in some cases
+- [#226](https://github.com/steevanb/php-parallel-processes/issues/226) Add compatibility with Symfony 6.3
+- [#228](https://github.com/steevanb/php-parallel-processes/issues/228) Execute phpstan for each Symfony version
+
 ### [0.11.0](../../compare/0.10.0...0.11.0) - 2023-04-05
 
 - [BC Break] Replace `ProcessArray` by `ProcessInterfaceArray`

config/ci/phpstan.php-8.1.neon

@@ -0,0 +1,4 @@
+includes:
+    - phpstan.neon
+parameters:
+    tmpDir: ../../var/ci/phpstan/php-8-1/symfony-6-1

config/ci/phpstan.php-8.1.symfony-6.1.neon

@@ -0,0 +1,4 @@
+includes:
+    - phpstan.neon
+parameters:
+    tmpDir: ../../var/ci/phpstan/php-8-1/symfony-6-2

config/ci/phpstan.php-8.1.symfony-6.2.neon

@@ -0,0 +1,4 @@
+includes:
+    - phpstan.neon
+parameters:
+    tmpDir: ../../var/ci/phpstan/php-8-1/symfony-6-3