More sniffs that can be added from slevomat

[sunkan]

Rules to look at

• SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses
• SlevomatCodingStandard.Namespaces.DisallowGroupUse
• SlevomatCodingStandard.Namespaces.MultipleUsesPerLine
• SlevomatCodingStandard.Namespaces.UseDoesNotStartWithBackslash
• SlevomatCodingStandard.Arrays.DisallowImplicitArrayCreation
• SlevomatCodingStandard.Attributes.DisallowAttributesJoining
• SlevomatCodingStandard.Attributes.DisallowMultipleAttributesPerLine
• SlevomatCodingStandard.Classes.ClassLength
  
• SlevomatCodingStandard.ControlStructures.DisallowYodaComparison
• SlevomatCodingStandard.Exceptions.DeadCatch

---

Rules to experiment with:

• SlevomatCodingStandard.Classes.ClassStructure
• SlevomatCodingStandard.ControlStructures.AssignmentInCondition
  
• SlevomatCodingStandard.Files.TypeNameMatchesFileName
  

[dcolt]

All errors are combined across all projects that I currently have locally.

• SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses 566 errors found
• SlevomatCodingStandard.Namespaces.DisallowGroupUse 0 errors found
• SlevomatCodingStandard.Namespaces.MultipleUsesPerLine 0 errors found
• SlevomatCodingStandard.Namespaces.UseDoesNotStartWithBackslash 0 errors found
• SlevomatCodingStandard.Arrays.DisallowImplicitArrayCreation 28 errors found
• SlevomatCodingStandard.Attributes.DisallowAttributesJoining 0 errors found
• SlevomatCodingStandard.Attributes.DisallowMultipleAttributesPerLine 0 errors found
• SlevomatCodingStandard.Classes.ClassLength 10 errors found (Longest class currently 351 lines, default setting max 250)
• SlevomatCodingStandard.ControlStructures.DisallowYodaComparison 3 errors found
• SlevomatCodingStandard.Exceptions.DeadCatch 0 errors found

[dcolt]

SlevomatCodingStandard.ControlStructures.AssignmentInCondition 3 errors found
But none that seems to be "required", all of them are in if statements and cloud easily be moved out of there.

[dcolt]

@sunkan SlevomatCodingStandard.Classes.ClassStructure Do we have any particular order we do want to have things? As it sadly doesn't seem to be consistent across everything.

Not even properties are always before methods.

[dcolt]

SlevomatCodingStandard.Files.TypeNameMatchesFileName I fail to see our usecase for this one, as we are following PSR-4. That's only for namespaces that doesn't follow the PSR-0 or PSR-4 as I understand.

And even so, it would be needed to be configured per project?

[sunkan]

SlevomatCodingStandard.ControlStructures.AssignmentInCondition 3 errors found But none that seems to be "required", all of them are in if statements and cloud easily be moved out of there.

Lets skip this one for now

@sunkan SlevomatCodingStandard.Classes.ClassStructure Do we have any particular order we do want to have things? As it sadly doesn't seem to be consistent across everything.

Not even properties are always before methods.

I think we should open a separate issue for this so we can more easy have a discussion about the order

SlevomatCodingStandard.Files.TypeNameMatchesFileName I fail to see our usecase for this one, as we are following PSR-4. That's only for namespaces that doesn't follow the PSR-0 or PSR-4 as I understand.

And even so, it would be needed to be configured per project?

In the perfect case this should never happen.

But for example in the account package you worked on I hade to fix multiple files with wrong namespaces that I think this would have caught