Summary
Both metrics endpoints now require an explicit metrics query parameter. Current CLI calls omit it.
Repro
eightctl metrics summary -v
eightctl metrics aggregate -v
Actual
Both return:
{
"errors": {
"metrics": ["The metrics field is required."]
}
}Expected
Commands should work out-of-the-box with sensible defaults.
Suggested Fix
Include metrics=all by default:
GET /users/<userId>/metrics/summary?metrics=allGET /users/<userId>/metrics/aggregate?v2=true&metrics=all
Optionally add --metrics CLI flag later for narrower queries.
I have implemented and use this fix on a local fork, feel free to reference my implementation diff: https://gist.github.com/0xble/28a12cd4d0876c063f63b07e4993434a
Environment
- macOS (Apple Silicon)
eightctl 0.1.0-dev
Summary
Both metrics endpoints now require an explicit
metricsquery parameter. Current CLI calls omit it.Repro
Actual
Both return:
{ "errors": { "metrics": ["The metrics field is required."] } }Expected
Commands should work out-of-the-box with sensible defaults.
Suggested Fix
Include
metrics=allby default:GET /users/<userId>/metrics/summary?metrics=allGET /users/<userId>/metrics/aggregate?v2=true&metrics=allOptionally add
--metricsCLI flag later for narrower queries.I have implemented and use this fix on a local fork, feel free to reference my implementation diff: https://gist.github.com/0xble/28a12cd4d0876c063f63b07e4993434a
Environment
eightctl 0.1.0-dev