Minor fixes

Author: stevapple

Sources/Basics/FileSystem+Extensions.swift

@@ -127,14 +127,10 @@ extension FileSystem {
 extension FileSystem {
     public func getOrCreateSwiftScriptCacheDirectory() throws -> AbsolutePath {
         let idiomaticCacheDirectory = self.swiftScriptCacheDirectory
-        // Create idiomatic if necessary
+        // Create if necessary
         if !self.exists(idiomaticCacheDirectory) {
             try self.createDirectory(idiomaticCacheDirectory, recursive: true)
         }
-        // Create ~/.swiftpm if necessary
-        if !self.exists(self.dotSwiftPM) {
-            try self.createDirectory(self.dotSwiftPM, recursive: true)
-        }
         return idiomaticCacheDirectory
     }
 }

Sources/Commands/Error.swift

@@ -54,7 +54,7 @@ func print(error: Any) {
 
 func print(diagnostic: Diagnostic, stdoutStream: OutputByteStream) {
 
-    let writer = InteractiveWriter.stderr
+    let writer = InteractiveWriter(stream: stdoutStream)
 
     if !(diagnostic.location is UnknownLocation) {
         writer.write(diagnostic.location.description)
@@ -78,6 +78,12 @@ func print(diagnostic: Diagnostic, stdoutStream: OutputByteStream) {
     writer.write("\n")
 }
 
+extension Diagnostic: ByteStreamable {
+    public func write(to stream: WritableByteStream) {
+        print(diagnostic: self, stdoutStream: stream)
+    }
+}
+
 /// This class is used to write on the underlying stream.
 ///
 /// If underlying stream is a not tty, the string will be written in without any

Sources/Commands/SwiftScriptTool.swift

@@ -91,8 +91,8 @@ extension SwiftScriptTool {
         @OptionGroup()
         var options: ScriptToolOptions
 
-        /// Whether to print build progress.
-        @Flag(help: "Print build progress")
+        /// Whether to show build output.
+        @Flag(help: "Print build output")
         var quiet: Bool = false
 
         func run(_ swiftTool: SwiftTool, as productName: String, at cacheDirPath: AbsolutePath) throws {
@@ -102,9 +102,7 @@ extension SwiftScriptTool {
             } else {
                 swiftTool.redirectStdoutToStderr()
             }
-            // FIXME: More elegant solution?
-            print(diagnostic: .init(message: .note("Using cache: \(cacheDirPath.basename)")),
-                  stdoutStream: swiftTool.stdoutStream)
+            swiftTool.stdoutStream <<< Diagnostic(message: .note("Using cache: \(cacheDirPath.basename)"))
 
             do {
                 let buildSystem = try swiftTool.createBuildSystem(explicitProduct: nil)

Sources/ScriptParse/ScriptParse.swift

@@ -93,7 +93,7 @@ extension ScriptParse {
     public func run() throws {
         let path = try AbsolutePath(validating: file)
         let json = try ScriptParse.manifest(for: path)
-        print(String(data: json, encoding: .utf8)!)
+        print(String(decoding: json, as: UTF8.self))
     }
 
     // FIXME: This should be removed some day.