Unused variables

[wcsicmp]

I wanted to write a documentation for this library, so i digged into source code (for VEH hooks especially). First of all, why not use inline static variables instead of regular static? Secondly, why don't check the result of VirtualProtect in mem_protect? If the function fails, it will trigger an exception and crush the program. I also suggest using [[nodiscard]] in getProtectionObject() of BreakPointHook, becuase if we don't save the result to local variable, the hook will be restored instantly, which will cause an infinity loop upon calling original function. Thirdly, PLH::AVehHook::Handler checks for m_onException and m_onUnhandledException, but you can't specify it, because library does not have an interface for that. Same goes for range-based type of VEH hook. Also if you have two hooks for the same address, the behavior is undefined, because hooks are stored in set. Thats what i spotted by glancing through the code. If the changes are acceptable, i am happy to make a commit. Let me know if the documentation is needed.

[stevemk14ebr]

Thanks for taking an interest in the project, would absolutely love improvements to both the documentation and the code if you wanted to contribute!

The short answer to most of your questions is because my code isn't perfect and could be better! For your specific questions:

• inline static variables instead of regular static

I don't believe applying inline to static local variables will change the behavior at all. If there is an improvement that adding inline would solve, lets do it

• check the result of VirtualProtect in mem_protect

Should definitely be doing this, there are many short comings of how allocation works in the project and the error conditions being handled gracefully in general. Of these types of issues #206 is by far the greatest problem.

• [[nodiscard]] in getProtectionObject()

great suggestion as well

The other suggestions about catching more mis-uses of the library are also correct and would be good improvements! As you have desire and time I would happily review patches (just please send me smaller patches one at a time to make review easier).