Python 3 support

[jayvdb]

I am seeing a few errors

self = <Container(<module 'data' from 'C:\\Projects\\py\\pynaut\\test\\data.py'>) >

    @property
    def children(self):
        _dict = {}
        for name in dir(self.obj):
            try:
                _dict[name] = getattr(self.obj, name)
            except Exception as e:
                logger.warn('Having to return dummy value for attribute "{0}" (error: {1})'.format(name, str(e)))
                _dict[name] = DUMMY_VALUE
>       for attr, value in _dict.iteritems():
E       AttributeError: 'dict' object has no attribute 'iteritems'

.tox\py310\lib\site-packages\pynaut\main.py:102: AttributeError

    def test_convenience_functions():
        """Test the various methods that wrap get_attr_matches.
        """
        obj = Container(data)

>       base_types = [t for t in vars(types).values() if isinstance(t, types.TypeType)]

test\test_all.py:50:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

.0 = <dict_valueiterator object at 0x0000022649F2A6B0>

>   base_types = [t for t in vars(types).values() if isinstance(t, types.TypeType)]
E   AttributeError: module 'types' has no attribute 'TypeType'

[stnbu]

Hey, thanks for the report! This is all ancient code as you can see. And my recollection is that it never did anything very useful (to me). So I'm flattered and pleased that you even thought to stop by and try it! Thanks!

How did you encounter the above error? Can I easily reproduce it? I know that .iteritems can now be replaced with .items, I'm not sure what's up with TypeType just yet.

With python version 3.9.13, if I change .iteritems to .items I can run the tests and I only run into the TypeType issue. The types module doesn't have an obvious substitute (upon cursory inspection.) I honestly don't even remember what TypeType was supposed to represent ... maybe type?

I just pushed a couple of changes that should eliminate the some of these problems (no guarantee they won't introduce more!). With Python version 3.9.13 I can run the tests without issue. YMMV.

[jayvdb]

I was out and about looking for a way to grep for a value within an object, recursively. One approach would be to convert the object to json (or similar) and then use json-grep-alike-tool to find where the value is. However, your package on PyPI came up as a possible tool to do this, and https://launchpad.net/grasp seems to also cover similar territory (and I raised a Python 3 issue there too). pynaut seems to not provide a helper to do exactly what I need, but has plumbing that can be used to do it, as far as I can see.

I used pytest to find the above errors, in order to get a broad feel for how many different types of Python 3 failures there were. Thank you for fixing them. Now that I know you are interested in maintaining this project, I'll see if I can scratch my itch using it.

Ya, type in Python 2 and earlier has been rolled into class in Python 3.

When I run the tests on Python 3.10 on Windows, I now get one more failure

    def test_testdata():
        """Some fairly complex tests that are known to give a particular result with the test data.
        """
        obj = Container(data)

        test = lambda c: c.name.lower().startswith('a')

        results = [
        len(list(obj.grep_attr_names('^S'))),
        len(list(obj.grep_attr_names('_$'))),
        len(list(obj.grep_attr_names('^real$'))),
        len(list(obj.get_attr_matches(test))),
        ]
        expected = [2, 0, 489, 577]
>       assert expected == results
E       assert [2, 0, 489, 577] == [2, 0, 494, 582]
E         At index 2 diff: 489 != 494
E         Use -v to get more diff

On Windows Python 3.8 & 3.9, it is slightly different:

    def test_testdata():
        """Some fairly complex tests that are known to give a particular result with the test data.
        """
        obj = Container(data)

        test = lambda c: c.name.lower().startswith('a')

        results = [
        len(list(obj.grep_attr_names('^S'))),
        len(list(obj.grep_attr_names('_$'))),
        len(list(obj.grep_attr_names('^real$'))),
        len(list(obj.get_attr_matches(test))),
        ]
        expected = [2, 0, 489, 577]
>       assert expected == results
E       assert [2, 0, 489, 577] == [2, 0, 493, 578]
E         At index 2 diff: 489 != 493
E         Use -v to get more diff