HTTPS FIX

Author: stopsopa

.env.template renamed to .env.pipeline

@@ -6,6 +6,13 @@ if [ "${NODE_API_PORT}" = "" ]; then
   exit 1;
 fi
 
+if [ "${NODE_API_PORT_HTTPS}" = "" ]; then
+
+  echo "${0} error: NODE_API_PORT_HTTPS is not defined"
+
+  exit 1;
+fi
+
 if [ "${LOCAL_HOSTS}" = "" ]; then
 
   echo "${0} error: LOCAL_HOSTS is not defined"

.env.sh

@@ -29,6 +29,9 @@
  *
  *    TIMEOUT="500" node .github/healtcheck.js front
  *
+ * to change port:
+ *    NODE_API_PORT=8888 node .github/healtcheck.js
+ *
  */
 // const path = require("path");
 import path from "path";
@@ -72,16 +75,6 @@ if (/^\d+$/.test(process.env.TIMEOUT)) {
       path: env,
     });
 
-    const protMatch = /^https?$/;
-
-    if (!protMatch.test(process.env.NODE_API_PROTOCOL)) {
-      throw th(`process.env.NODE_API_PROTOCOL >${process.env.NODE_API_PROTOCOL}< doesn't match pattern ${protMatch}`);
-    }
-
-    if (typeof process.env.NODE_API_PORT_HTTPS !== "string") {
-      throw th(`NODE_API_PORT_HTTPS is undefined`);
-    }
-
     setTimeout(() => {
       logger(
         `healthcheck timeout error after ${healthcheckTimeoutMilliseconds} miliseconds (${parseFloat(
@@ -92,7 +85,7 @@ if (/^\d+$/.test(process.env.TIMEOUT)) {
       process.exit(1);
     }, healthcheckTimeoutMilliseconds);
 
-    const server_front_endpoint = `${process.env.NODE_API_PROTOCOL}://0.0.0.0:${process.env.NODE_API_PORT_HTTPS}/healthcheck`;
+    const server_front_endpoint = `${process.env.NODE_API_PROTOCOL}://0.0.0.0:${process.env.NODE_API_PORT}/healthcheck`;
 
     const promise = Promise.all([
       new Promise((resolve) => {

.github/healtcheck.js

@@ -109,7 +109,7 @@ jobs:
 
       - name: Build
         run: |
-          cp .env.template .env          
+          cp .env.pipeline .env          
           /bin/bash build.sh
 
       - name: run local server (NODE_ENV=production)
@@ -118,12 +118,13 @@ jobs:
 
       - name: servers healthchecks
         run: |
-          TIMEOUT="2000" node .github/healtcheck.js
+          source .env
+          source .env.sh
+          NODE_API_PORT="${NODE_API_PORT_HTTPS}" TIMEOUT="2000" node .github/healtcheck.js
       # - name: test cli (using routes endpoint)
       #   run: |
       #     /bin/bash console.sh routes
       - name: UNIT TESTS
-        # if: "!contains(github.event.head_commit.message, '[q]')"
         if: |
           !(github.event.head_commit.message == 'q' || 
             startsWith(github.event.head_commit.message, 'q ') || 
@@ -136,24 +137,25 @@ jobs:
       #     TYPE=int /bin/bash test.sh
 
       - name: JASMINE TESTS
-        # if: "!contains(github.event.head_commit.message, '[q]')"
         if: |
           !(github.event.head_commit.message == 'q' ||
             startsWith(github.event.head_commit.message, 'q ') ||
             endsWith(github.event.head_commit.message, ' q') ||
             contains(github.event.head_commit.message, ' q '))
         run: |
+          # this script is launching koa server, using it and killing it, so it can be ran on any arbitrary port
           NODE_API_PORT=4273 /bin/bash jasmine/test.sh --env .env -- --target docker
 
       - name: E2E TESTS
-        # if: "!contains(github.event.head_commit.message, '[q]')"
         if: |
           !(github.event.head_commit.message == 'q' ||
             startsWith(github.event.head_commit.message, 'q ') ||
             endsWith(github.event.head_commit.message, ' q') ||
             contains(github.event.head_commit.message, ' q '))
         run: |
-          /bin/bash playwright.sh --target docker
+          source .env
+          source .env.sh
+          NODE_API_PORT="${NODE_API_PORT_HTTPS}" /bin/bash playwright.sh --target docker
 
       - name: ps aux
         run: |

.github/workflows/pipeline.yml

@@ -6,6 +6,7 @@
 # Lifecycle phases of this script:
 #     Generally what this script is doing is perparing (bundling) all desired test files to be delivered to the browser context.
 #     Then it launches temporary http server for playwright testing.
+#          (NOTE: for that you can use any arbitrary port, recommended is to override NODE_API_PORT env var to some free port)
 #     All tests are executed (using jasmine-core lib) in the browser after load and result of all tests are fetched.
 #     Testing in playwright is done with just one test with one expect().toEqual() 
 #     comparing desired state of fetched states with desired state.
@@ -367,6 +368,9 @@ EEE
 # echo 'wait'
 # read -n 1
 
+
+# this will launch on http and https ports
+# so it will use NODE_API_PORT and NODE_API_PORT_HTTPS env vars
 NODE_OPTIONS="" node "${_DIR}/server_koa.js" --web "${ROOT}" --asset_list "${ASSETLIST}" --env "${ENVFILE}" 1>> "${LOGFILE}" 2>> "${LOGFILE}" & disown
 
 set +x

jasmine/test.sh

@@ -51,15 +51,6 @@ if (typeof process.env.ENVFILE === "string" && process.env.ENVFILE.trim()) {
   dotenv.config();
 }
 
-
-// WARNING: this is tweak introduced with introduction of https for local development vvv
-// WARNING: this is tweak introduced with introduction of https for local development vvv
-// WARNING: this is tweak introduced with introduction of https for local development vvv
-process.env.NODE_API_PORT = process.env.NODE_API_PORT_HTTPS;
-// WARNING: this is tweak introduced with introduction of https for local development ^^^
-// WARNING: this is tweak introduced with introduction of https for local development ^^^
-// WARNING: this is tweak introduced with introduction of https for local development ^^^
-
 mockEnv(process.env);
 
 const protocolRegex = /^https?:\/\//;
@@ -169,18 +160,12 @@ const config = {
       name: "chromium",
       use: {
         ...devices["Desktop Chrome"],
-        launchOptions: {
-          args: ["--ignore-certificate-errors"], // https://stackoverflow.com/a/76610601
-        },
       },
     },
     {
       name: "firefox",
       use: {
         ...devices["Desktop Firefox"],
-        launchOptions: {
-          args: ["--ignore-certificate-errors"], // https://stackoverflow.com/a/76610601
-        },
       },
     },
     // { // too much problems with running tests - commenting out
@@ -229,6 +214,37 @@ const config = {
   // },
 };
 
+if (protocolRegex.test(process.env.BASE_URL)) {
+  log(`BASE_URL https protocol detected: ${process.env.BASE_URL} - tweaking configuration`);
+
+  // Add ignoreHTTPSErrors to global use configuration
+  config.use.ignoreHTTPSErrors = true;
+
+  // Configure enhanced SSL error handling for Chromium
+  const chromiumProject = config.projects.find((p) => p.name === "chromium");
+  if (chromiumProject) {
+    chromiumProject.use.launchOptions = {
+      args: [
+        "--ignore-certificate-errors",
+        "--ignore-ssl-errors",
+        "--ignore-certificate-errors-spki-list",
+        "--disable-web-security",
+        "--allow-running-insecure-content",
+        "--disable-features=VizDisplayCompositor",
+      ], // Enhanced SSL error handling for self-signed certificates
+    };
+    log(`Chromium SSL configuration tweaks applied`);
+  }
+
+  // Configure SSL error handling for Firefox
+  const firefoxProject = config.projects.find((p) => p.name === "firefox");
+  if (firefoxProject) {
+    firefoxProject.use.launchOptions = {
+      args: ["--ignore-certificate-errors"], // Firefox uses different flags
+    };
+    log(`Firefox SSL configuration tweaks applied`);
+  }
+}
 /**
  * Above just standard default config, and below we will modify it the way we need
  */

playwright.config.js

@@ -90,7 +90,7 @@ cat <<EEE
 
 EEE
 
-TIMEOUT="2000" node .github/healtcheck.js
+NODE_API_PORT="${NODE_API_PORT_HTTPS}" TIMEOUT="2000" node .github/healtcheck.js
 
 cat <<EEE
 
@@ -114,4 +114,5 @@ cat <<EEE
 
 EEE
 
-/bin/bash playwright.sh
+# because we have launched koa server via https let's switch playwright to use https as well
+NODE_API_PORT="${NODE_API_PORT_HTTPS}" /bin/bash playwright.sh

testall.sh

@@ -114,6 +114,7 @@ cat <<EEE
 /bin/bash jasmine/test.sh --env .env
 
 NODE_API_PORT=4273 /bin/bash jasmine/test.sh --env .env -- --target docker
+NODE_API_PORT=4273 /bin/bash jasmine/test.sh --env .env -- -- --debug
 
 NODE_API_PORT=4273 /bin/bash jasmine/test.sh ${S}
       --env .env ${S}