Donation Amount Not Saved When Using Pay by Check Gateway

[davidmutero]

Describe the bug
When a user makes a donation at checkout using the Pay by Check (PBC) gateway, the donation amount is not saved under the “Additional Order Information” for the order. This works as expected with other gateways like Stripe and Stripe Checkout, where the donation amount is stored correctly. The donation note is saved to the invoice, but the donation amount is missing.

To Reproduce
Steps to reproduce the behavior:

1. Install and activate Paid Memberships Pro,Pay by Check Add On and the Donations Add On.
2. Configure a membership level to accept donation and Pay by Check gateway as the only payment method or include it as a option.
3. Proceed to and complete checkout for a membership level and add a donation amount and choose Pay by Check method.
4. View the order in the admin area and confirm that the donation amount is missing (Set to 0) from the “Additional Order Information” section

Screenshots

Expected behavior
The donation amount entered by the member should be saved and displayed in the “Additional Order Information” section of the order, consistent with the behavior when using gateways like Stripe.

Isolating the problem (mark completed items with an [x]):

• I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
• This bug happens with a default WordPress theme active, or Memberlite.
• I can reproduce this bug consistently using the steps above.

WordPress Environment

Details

``` WordPress Version: 6.7.2 PHP Version: 7.4.33 Paid Memberships Pro: v3.4.6 Donations Add On: v2.2 Pay by Check Add On: v1.1.3 Server: Apache/2.4.57 (Ubuntu) Site Language: en_US User Language: en_US. ```

[dparker1005]

After looking into this further, here's the core of the issue.

The Pay By Check order completes a checkout when an order is moved to "success" status. This is typically done by an administrator saving an order in the admin.

When an order is edited in the admin with the Donations Add On active, there is a field on the Edit Order screen for the donation amount.

So what is happening in this case is:

• User submits checkout with donation and check payment
• Order is created in Pending status
• Edit order page is loaded by admin with $0 in the donation field
• Admin changes order to success and saves
• Checkout completes via Pay By Check
• As a part of checkout completion, order donation amount is updated to the correct amount
• Then the rest of the order save process finishes. Since $0 was present in the donation field on the edit order page, the donation amount is then set back to $0

So then what is the solution here? Either we need to:

1. Add code to the Donations Add On to avoid updating the donation amount on the Edit Order page when the order is completed via PBC
2. Update PBC to have a "confirm payment" flow that doesn't trigger the rest of the "Edit Order" save flow. This is probably the best long-term solution as it would avoid similar issues with other Add Ons