Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Commit d8185c9

Browse files
Merge pull request #102 from liuyang25/fix_timestamp_missed
fix created_at and updated_at not migrated issue
2 parents 5ec7299 + 1e838cb commit d8185c9

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

v3-sql-v4-sql/migrate/migrateModels.js

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -42,23 +42,14 @@ async function migrateModels(tables) {
4242
if (modelDef.options.timestamps === false) {
4343
return migrateItem(item);
4444
} else {
45-
const timestamps =
46-
modelDef.options.timestamps === true
47-
? ['created_at', 'updated_at']
48-
: modelDef.options.timestamps;
49-
const [createdAt, updatedAt] = timestamps;
50-
45+
// v3-mongo->v3-sql already rename them to these snake case, but kept the customized field, then in v4-sql custom createdAt will be covered.
5146
const newItem = {
5247
...item,
53-
created_at: item[createdAt],
54-
updated_at: item[updatedAt],
48+
created_at: item['created_at'],
49+
updated_at: item['updated_at'],
5550
};
5651

57-
let omitFields = [...omitAttributes];
58-
if (createdAt != 'created_at') omitFields.push(createdAt);
59-
if (updatedAt != 'updated_at') omitFields.push(updatedAt);
60-
61-
return migrateItem(omit(newItem, omitFields));
52+
return migrateItem(omit(newItem, omitAttributes));
6253
}
6354
});
6455
}

0 commit comments

Comments
 (0)