Update CPU resourceProfile to use 4Gi mem and fix cpu model profiles #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samos123
approved these changes
Feb 21, 2025
|
@nstogner can you rebase and re-trigger? |
|
Looks like tests are failing with OOM, will debug soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested the CPU models to see what memory requirements they had (
kubectl top pods). Updated thecpuresourceProfile to request 4Gi of memory per core. This matches common cloud machine shapes and avoids the need to specify a extremely highcpu:NresourceProfile for models to match their memory requirements.Fixes #418 - Which turned out to be an OOM issue (error appears to have been suppressed).