Skip to content

Commit 6ab1468

Browse files
committed
fixup! ✨(frontend) add comments feature
1 parent b85f464 commit 6ab1468

File tree

6 files changed

+209
-212
lines changed

6 files changed

+209
-212
lines changed

src/frontend/apps/impress/package.json

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919
},
2020
"dependencies": {
2121
"@ag-media/react-pdf-table": "2.0.3",
22-
"@blocknote/code-block": "0.41.1",
23-
"@blocknote/core": "0.41.1",
24-
"@blocknote/mantine": "0.41.1",
25-
"@blocknote/react": "0.41.1",
26-
"@blocknote/xl-docx-exporter": "0.41.1",
27-
"@blocknote/xl-multi-column": "0.41.1",
28-
"@blocknote/xl-pdf-exporter": "0.41.1",
22+
"@blocknote/code-block": "0.42.0",
23+
"@blocknote/core": "0.42.0",
24+
"@blocknote/mantine": "0.42.0",
25+
"@blocknote/react": "0.42.0",
26+
"@blocknote/xl-docx-exporter": "0.42.0",
27+
"@blocknote/xl-multi-column": "0.42.0",
28+
"@blocknote/xl-pdf-exporter": "0.42.0",
2929
"@dnd-kit/core": "6.3.1",
3030
"@dnd-kit/modifiers": "9.0.0",
3131
"@emoji-mart/data": "1.2.1",
@@ -42,7 +42,6 @@
4242
"@react-pdf/renderer": "4.3.1",
4343
"@sentry/nextjs": "10.22.0",
4444
"@tanstack/react-query": "5.90.6",
45-
"@tiptap/extensions": "3.10.1",
4645
"canvg": "4.0.3",
4746
"clsx": "2.1.1",
4847
"cmdk": "1.1.1",

src/frontend/apps/impress/src/features/docs/doc-editor/components/comments/styles.tsx

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@ export const cssComments = (
1515
}
1616
}
1717
18+
em-emoji-picker {
19+
box-shadow: 0px 6px 18px 0px #00001229;
20+
min-height: 420px;
21+
}
22+
1823
// Thread modal
1924
.bn-thread {
2025
width: 400px;
@@ -44,16 +49,6 @@ export const cssComments = (
4449
.bn-thread-comments {
4550
overflow: auto;
4651
max-height: 500px;
47-
48-
// to allow popovers to escape the thread container
49-
&:has(em-emoji-picker) {
50-
max-height: none;
51-
overflow: visible;
52-
}
53-
54-
em-emoji-picker {
55-
box-shadow: 0px 6px 18px 0px #00001229;
56-
}
5752
}
5853
5954
.bn-thread-comment {

src/frontend/apps/impress/src/features/docs/doc-editor/components/custom-blocks/CalloutBlock.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,5 +173,4 @@ export const getCalloutFormattingToolbarItems = (
173173
name: t('Callout'),
174174
type: 'callout',
175175
icon: () => <Icon iconName="lightbulb" $size="16px" />,
176-
isSelected: (block) => block.type === 'callout',
177176
});

src/frontend/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
"@typescript-eslint/parser": "8.46.2",
3939
"docx": "9.5.0",
4040
"eslint": "9.39.0",
41+
"prosemirror-state": "1.4.3",
4142
"react": "19.2.0",
4243
"react-dom": "19.2.0",
4344
"typescript": "5.9.3",

src/frontend/servers/y-provider/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"node": ">=22"
1717
},
1818
"dependencies": {
19-
"@blocknote/server-util": "0.41.1",
19+
"@blocknote/server-util": "0.42.0",
2020
"@hocuspocus/server": "3.4.0",
2121
"@sentry/node": "10.22.0",
2222
"@sentry/profiling-node": "10.22.0",
@@ -30,7 +30,7 @@
3030
"yjs": "*"
3131
},
3232
"devDependencies": {
33-
"@blocknote/core": "0.41.1",
33+
"@blocknote/core": "0.42.0",
3434
"@hocuspocus/provider": "3.4.0",
3535
"@types/cors": "2.8.19",
3636
"@types/express": "5.0.5",

0 commit comments

Comments
 (0)