Skip to content

Commit 7d98db8

Browse files
committed
⬆️(dependencies) upgrade Blocknote to last version
Last version of Blocknote includes fixes for some issues related to comments. It introduces as well a bug about "previewWidth", plus compatibility issues with "prosemirror-state". This commit fixes those issues.
1 parent 6ad8564 commit 7d98db8

File tree

7 files changed

+292
-210
lines changed

7 files changed

+292
-210
lines changed

src/frontend/apps/impress/package.json

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919
},
2020
"dependencies": {
2121
"@ag-media/react-pdf-table": "2.0.3",
22-
"@blocknote/code-block": "0.41.1",
23-
"@blocknote/core": "0.41.1",
24-
"@blocknote/mantine": "0.41.1",
25-
"@blocknote/react": "0.41.1",
26-
"@blocknote/xl-docx-exporter": "0.41.1",
27-
"@blocknote/xl-multi-column": "0.41.1",
28-
"@blocknote/xl-pdf-exporter": "0.41.1",
22+
"@blocknote/code-block": "0.42.0",
23+
"@blocknote/core": "0.42.0",
24+
"@blocknote/mantine": "0.42.0",
25+
"@blocknote/react": "0.42.0",
26+
"@blocknote/xl-docx-exporter": "0.42.0",
27+
"@blocknote/xl-multi-column": "0.42.0",
28+
"@blocknote/xl-pdf-exporter": "0.42.0",
2929
"@dnd-kit/core": "6.3.1",
3030
"@dnd-kit/modifiers": "9.0.0",
3131
"@emoji-mart/data": "1.2.1",
@@ -42,7 +42,8 @@
4242
"@react-pdf/renderer": "4.3.1",
4343
"@sentry/nextjs": "10.22.0",
4444
"@tanstack/react-query": "5.90.6",
45-
"@tiptap/extensions": "3.10.1",
45+
"@tiptap/core": "3.10.5",
46+
"@tiptap/extensions": "3.10.5",
4647
"canvg": "4.0.3",
4748
"clsx": "2.1.1",
4849
"cmdk": "1.1.1",

src/frontend/apps/impress/src/features/docs/doc-editor/components/BlockNoteEditor.tsx

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,54 @@ import XLMultiColumn from './xl-multi-column';
5353
const multiColumnLocales = XLMultiColumn?.locales;
5454
const withMultiColumn = XLMultiColumn?.withMultiColumn;
5555

56+
// Patch video/file/audio blocks to have a valid number default for previewWidth
57+
// This fixes the ProseMirror error: "No value supplied for attribute previewWidth"
58+
// BlockNote's default blocks use `undefined` which causes runtime errors
59+
const patchedVideoBlock = {
60+
...defaultBlockSpecs.video,
61+
config: {
62+
...defaultBlockSpecs.video.config,
63+
propSchema: {
64+
...defaultBlockSpecs.video.config.propSchema,
65+
previewWidth: { default: 512, type: 'number' as const },
66+
},
67+
},
68+
};
69+
70+
const patchedFileBlock = {
71+
...defaultBlockSpecs.file,
72+
config: {
73+
...defaultBlockSpecs.file.config,
74+
propSchema: {
75+
...defaultBlockSpecs.file.config.propSchema,
76+
previewWidth: { default: 512, type: 'number' as const },
77+
},
78+
},
79+
};
80+
81+
const patchedAudioBlock = {
82+
...defaultBlockSpecs.audio,
83+
config: {
84+
...defaultBlockSpecs.audio.config,
85+
propSchema: {
86+
...defaultBlockSpecs.audio.config.propSchema,
87+
previewWidth: { default: 512, type: 'number' as const },
88+
},
89+
},
90+
};
91+
5692
const baseBlockNoteSchema = withPageBreak(
5793
BlockNoteSchema.create({
5894
blockSpecs: {
5995
...defaultBlockSpecs,
96+
audio: patchedAudioBlock,
6097
callout: CalloutBlock(),
6198
codeBlock: createCodeBlockSpec(codeBlockOptions),
99+
file: patchedFileBlock,
62100
image: AccessibleImageBlock(),
63101
pdf: PdfBlock(),
64102
uploadLoader: UploadLoaderBlock(),
103+
video: patchedVideoBlock,
65104
},
66105
inlineContentSpecs: {
67106
...defaultInlineContentSpecs,

src/frontend/apps/impress/src/features/docs/doc-editor/components/custom-blocks/CalloutBlock.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,5 +173,4 @@ export const getCalloutFormattingToolbarItems = (
173173
name: t('Callout'),
174174
type: 'callout',
175175
icon: () => <Icon iconName="lightbulb" $size="16px" />,
176-
isSelected: (block) => block.type === 'callout',
177176
});

src/frontend/apps/impress/src/features/docs/doc-editor/components/custom-blocks/PdfBlock.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ type CreatePDFBlockConfig = BlockConfig<
3636
backgroundColor: { default: 'default' };
3737
caption: { default: '' };
3838
name: { default: '' };
39-
previewWidth: { default: undefined; type: 'number' };
39+
previewWidth: { default: 512; type: 'number' };
4040
showPreview: { default: true };
4141
textAlignment: { default: 'left' };
4242
url: { default: '' };
@@ -117,7 +117,7 @@ export const PdfBlock = createReactBlockSpec(
117117
backgroundColor: { default: 'default' as const },
118118
caption: { default: '' as const },
119119
name: { default: '' as const },
120-
previewWidth: { default: undefined, type: 'number' },
120+
previewWidth: { default: 512, type: 'number' },
121121
showPreview: { default: true },
122122
textAlignment: { default: 'left' as const },
123123
url: { default: '' as const },

src/frontend/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,9 @@
3636
"@types/react-dom": "19.2.2",
3737
"@typescript-eslint/eslint-plugin": "8.46.2",
3838
"@typescript-eslint/parser": "8.46.2",
39-
"docx": "9.5.0",
39+
"docx": "9.5.1",
4040
"eslint": "9.39.0",
41+
"prosemirror-state": "1.4.3",
4142
"react": "19.2.0",
4243
"react-dom": "19.2.0",
4344
"typescript": "5.9.3",

src/frontend/servers/y-provider/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"node": ">=22"
1717
},
1818
"dependencies": {
19-
"@blocknote/server-util": "0.41.1",
19+
"@blocknote/server-util": "0.42.0",
2020
"@hocuspocus/server": "3.4.0",
2121
"@sentry/node": "10.22.0",
2222
"@sentry/profiling-node": "10.22.0",
@@ -30,7 +30,7 @@
3030
"yjs": "*"
3131
},
3232
"devDependencies": {
33-
"@blocknote/core": "0.41.1",
33+
"@blocknote/core": "0.42.0",
3434
"@hocuspocus/provider": "3.4.0",
3535
"@types/cors": "2.8.19",
3636
"@types/express": "5.0.5",

0 commit comments

Comments
 (0)