Skip to content

Commit aeac49d

Browse files
committed
🔥(frontend) remove fix about color in export
The last version of Blocknote fixed the issue with colors in exports. We can remove our workaround now.
1 parent b5dcbbb commit aeac49d

File tree

4 files changed

+5
-98
lines changed

4 files changed

+5
-98
lines changed

CHANGELOG.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ and this project adheres to
88

99
### Added
1010

11-
- ✨(frontend) enable ODT export for documents #1524
11+
- ✨(export) enable ODT export for documents #1524
1212
- ✨(frontend) improve mobile UX by showing subdocs count #1540
1313

1414
### Fixed
@@ -17,13 +17,14 @@ and this project adheres to
1717
- ♿(frontend) improve ARIA in doc grid and editor for a11y #1519
1818
- ♿(frontend) improve accessibility and styling of summary table #1528
1919
- ♿(frontend) add focus trap and enter key support to remove doc modal #1531
20-
- 🐛(docx) fix image overflow by limiting width to 600px during export #1525
2120
- 🐛(frontend) preserve @ character when esc is pressed after typing it #1512
2221
- 🐛(frontend) make summary button fixed to remain visible during scroll #1581
2322
- 🐛(frontend) fix pdf embed to use full width #1526
2423
- 🐛(frontend) fix fallback translations with Trans #1620
25-
- 🐛(pdf) fix table cell alignment issue in exported documents #1582
26-
- 🐛(pdf) preserve image aspect ratio in PDF export #1622
24+
- 🐛(export) fix image overflow by limiting width to 600px during export #1525
25+
- 🐛(export) fix table cell alignment issue in exported documents #1582
26+
- 🐛(export) preserve image aspect ratio in PDF export #1622
27+
- 🐛(export) Export fails when paste with style #1552
2728

2829
### Security
2930

src/frontend/apps/impress/src/features/docs/doc-export/mappingDocx.tsx

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -39,39 +39,5 @@ export const docxDocsSchemaMappings: DocsExporterDocx['mappings'] = {
3939
shading: { fill: 'DCDCDC' },
4040
}
4141
: {},
42-
// If the color is not defined, we fall back to default colors
43-
backgroundColor: (val, exporter) => {
44-
if (!val) {
45-
return {};
46-
}
47-
48-
const backgroundColor = exporter.options.colors?.[val]?.background;
49-
50-
if (!backgroundColor) {
51-
return {};
52-
}
53-
54-
return {
55-
shading: {
56-
fill: backgroundColor.slice(1),
57-
},
58-
};
59-
},
60-
// If the color is not defined, we fall back to default colors
61-
textColor: (val, exporter) => {
62-
if (!val) {
63-
return {};
64-
}
65-
66-
const color = exporter.options.colors?.[val]?.text;
67-
68-
if (!color) {
69-
return {};
70-
}
71-
72-
return {
73-
color: color.slice(1),
74-
};
75-
},
7642
},
7743
};

src/frontend/apps/impress/src/features/docs/doc-export/mappingODT.ts

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -30,32 +30,4 @@ export const odtDocsSchemaMappings: DocsExporterODT['mappings'] = {
3030
interlinkingSearchInline: () => null,
3131
interlinkingLinkInline: inlineContentMappingInterlinkingLinkODT,
3232
},
33-
styleMapping: {
34-
...odtDefaultSchemaMappings.styleMapping,
35-
textColor: (val, exporter): Record<string, string> => {
36-
if (!val) {
37-
return {};
38-
}
39-
const color = exporter.options.colors?.[val]?.text;
40-
41-
if (!color) {
42-
return {};
43-
}
44-
45-
return { 'fo:color': color };
46-
},
47-
48-
backgroundColor: (val, exporter): Record<string, string> => {
49-
if (!val) {
50-
return {};
51-
}
52-
const color = exporter.options.colors?.[val]?.background;
53-
54-
if (!color) {
55-
return {};
56-
}
57-
58-
return { 'fo:background-color': color };
59-
},
60-
},
6133
};

src/frontend/apps/impress/src/features/docs/doc-export/mappingPDF.tsx

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -39,37 +39,5 @@ export const pdfDocsSchemaMappings: DocsExporterPDF['mappings'] = {
3939
// that is not available in italics
4040
code: (enabled?: boolean) =>
4141
enabled ? { fontFamily: 'Courier', backgroundColor: '#dcdcdc' } : {},
42-
// If the color is not defined, we fall back to default colors
43-
textColor: (val, exporter) => {
44-
if (!val) {
45-
return {};
46-
}
47-
48-
const color = exporter.options.colors?.[val]?.text;
49-
50-
if (!color) {
51-
return {};
52-
}
53-
54-
return {
55-
color,
56-
};
57-
},
58-
// If the color is not defined, we fall back to default colors
59-
backgroundColor: (val, exporter) => {
60-
if (!val) {
61-
return {};
62-
}
63-
64-
const backgroundColor = exporter.options.colors?.[val]?.background;
65-
66-
if (!backgroundColor) {
67-
return {};
68-
}
69-
70-
return {
71-
backgroundColor,
72-
};
73-
},
7442
},
7543
};

0 commit comments

Comments
 (0)