Merge pull request azavea#33 from azavea/feature/jrb/remove-iam-ec2-role

* Remove AmazonEC2ContainerServiceAutoscaleRole creation

* Remove data resource lookup

Author: rbreslow

README.md

@@ -90,8 +90,6 @@ module "container_service_cluster" {
 - `container_instance_security_group_id` - Security group ID of the EC2 container instances
 - `container_instance_ecs_for_ec2_service_role_name` - Name of IAM role associated with EC2 container instances
 - `ecs_service_role_name` - Name of IAM role for use with ECS services
-- `ecs_autoscale_role_name` - Name of IAM role for use with ECS service autoscaling
 - `ecs_service_role_arn` - ARN of IAM role for use with ECS services
-- `ecs_autoscale_role_arn` - ARN of IAM role for use with ECS service autoscaling
 - `container_instance_ecs_for_ec2_service_role_arn` - ARN of IAM role associated with EC2 container instances
 - `container_instance_autoscaling_group_name` - Name of container instance Autoscaling Group

main.tf

@@ -69,16 +69,6 @@ data "aws_iam_policy_document" "ecs_autoscale_assume_role" {
   }
 }
 
-resource "aws_iam_role" "ecs_autoscale_role" {
-  name               = "ecs${title(var.environment)}AutoscaleRole"
-  assume_role_policy = "${data.aws_iam_policy_document.ecs_autoscale_assume_role.json}"
-}
-
-resource "aws_iam_role_policy_attachment" "ecs_service_autoscaling_role" {
-  role       = "${aws_iam_role.ecs_autoscale_role.name}"
-  policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2ContainerServiceAutoscaleRole"
-}
-
 #
 # Security group resources
 #

outputs.tf

@@ -18,10 +18,6 @@ output "ecs_service_role_name" {
   value = "${aws_iam_role.ecs_service_role.name}"
 }
 
-output "ecs_autoscale_role_name" {
-  value = "${aws_iam_role.ecs_autoscale_role.name}"
-}
-
 output "container_instance_autoscaling_group_name" {
   value = "${aws_autoscaling_group.container_instance.name}"
 }
@@ -30,10 +26,6 @@ output "ecs_service_role_arn" {
   value = "${aws_iam_role.ecs_service_role.arn}"
 }
 
-output "ecs_autoscale_role_arn" {
-  value = "${aws_iam_role.ecs_autoscale_role.arn}"
-}
-
 output "container_instance_ecs_for_ec2_service_role_arn" {
   value = "${aws_iam_role.container_instance_ec2.arn}"
 }