Add dynamic auth token updates #11
Open
+236
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds update_auth/2 and :auth option for invoke/3 to support token rotation like JS client's setAuth(). Closes supabase-community#3
zoedsoupe
requested changes
Dec 1, 2025
Comment on lines
+132
to
+135
| case opts[:auth] do | ||
| nil -> client | ||
| auth_token when is_binary(auth_token) -> update_auth(client, auth_token) | ||
| end |
Member
There was a problem hiding this comment.
for only 2 logic branches, i would go with a simpler if/2, so we can follow the rest of project standard
| timeout = opts[:timeout] || 15_000 | ||
|
|
||
| client | ||
| # Handle auth token override |
Member
There was a problem hiding this comment.
Suggested change
| # Handle auth token override |
Comment on lines
+158
to
+164
| ### Benefits | ||
|
|
||
| - **Token rotation support**: Easily update tokens without recreating clients | ||
| - **Better performance**: Avoid the overhead of creating new client instances | ||
| - **Flexibility**: Use different tokens per request or update client globally | ||
| - **Feature parity**: Matches the JavaScript client's `setAuth()` functionality | ||
| - **Immutability**: Original client instances remain unchanged with functional updates |
Member
There was a problem hiding this comment.
i don't think this kind of content fits well on a README
Suggested change
| ### Benefits | |
| - **Token rotation support**: Easily update tokens without recreating clients | |
| - **Better performance**: Avoid the overhead of creating new client instances | |
| - **Flexibility**: Use different tokens per request or update client globally | |
| - **Feature parity**: Matches the JavaScript client's `setAuth()` functionality | |
| - **Immutability**: Original client instances remain unchanged with functional updates |
| - **Comprehensive timeout coverage**: Sets both receive timeout (per-chunk) and request timeout (complete response) | ||
| - **Feature parity with JS client**: Matches timeout functionality in the JavaScript SDK | ||
|
|
||
| ## Dynamic Auth Token Updates |
Member
There was a problem hiding this comment.
this section at all seems not to fit on a README file
| - **Request cancellation**: Long-running requests will timeout and be cancelled | ||
| - **Better resource management**: Prevents hanging connections | ||
| - **Comprehensive timeout coverage**: Sets both receive timeout (per-chunk) and request timeout (complete response) | ||
| - **Feature parity with JS client**: Matches timeout functionality in the JavaScript SDK |
Member
There was a problem hiding this comment.
existing section i know, but isn't necessary to explicit say we have feature parity with JS, this is implicit
| | {:region, region} | ||
| | {:on_response, on_response} | ||
| | {:timeout, pos_integer()} | ||
| | {:auth, String.t()} |
Member
There was a problem hiding this comment.
JS uses auth as the override token option key? maybe we could think on something like access_token or authorization_token, wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds update_auth/2 and :auth option for invoke/3 to support token rotation like JS client's setAuth(). Closes #3