feat: binary upgrades require max_slot_wal_keep_size to be -1 during binary upgrade

Author: samrose

ansible/files/admin_api_scripts/pg_upgrade_scripts/complete.sh

@@ -22,10 +22,8 @@ function cleanup {
 
     ship_logs "$LOG_FILE" || true
 
-    # Restore max_slot_wal_keep_size to 4096 only if both versions were PostgreSQL 17+
-    if [[ ("$OLD_PGVERSION" =~ ^17.* || "$OLD_PGVERSION" == "17-orioledb") && ("$PGVERSION" =~ ^17.* || "$PGVERSION" == "17-orioledb") ]]; then
-        sed -i 's/max_slot_wal_keep_size = -1/max_slot_wal_keep_size = 4096/' /etc/postgresql/postgresql.conf
-    fi
+    # Restore max_slot_wal_keep_size to 4096 after binary upgrade
+    sed -i 's/max_slot_wal_keep_size = -1/max_slot_wal_keep_size = 4096/' /etc/postgresql/postgresql.conf
 
     # Restart postgres to apply any configuration changes
     if [ -z "$IS_CI" ]; then

ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh

@@ -397,10 +397,8 @@ function initiate_upgrade {
     chown -R postgres:postgres "$MOUNT_POINT/"
     rm -rf "${PGDATANEW:?}/"
 
-    # Change max_slot_wal_keep_size to -1 for upgrade only if both versions are PostgreSQL 17+
-    if [[ ("$OLD_PGVERSION" =~ ^17.* || "$OLD_PGVERSION" == "17-orioledb") && ("$PGVERSION" =~ ^17.* || "$PGVERSION" == "17-orioledb") ]]; then
-        sed -i 's/max_slot_wal_keep_size = [0-9]*/max_slot_wal_keep_size = -1/' /etc/postgresql/postgresql.conf
-    fi
+    # Change max_slot_wal_keep_size to -1 for binary upgrade
+    sed -i 's/max_slot_wal_keep_size = [0-9]*/max_slot_wal_keep_size = -1/' /etc/postgresql/postgresql.conf
 
     if [ "$IS_NIX_UPGRADE" = "true" ]; then
         if [[ "$PGVERSION" =~ ^17.* || "$PGVERSION" == "17-orioledb" ]]; then