feat(ansible): add pgBackRest tasks and configurations #1878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfroche
reviewed
Oct 30, 2025
* origin/PSQL-773: fix(setup-pgbackrest.yml): errant indentation fix fix(setup-pgbackrest.yml): fix file module fix(setup-pgbackrest.yml): update nix install path feat(ansible): add pgBackRest tasks and configurations
The pgbackrest wrapper script now sanitizes arguments passed to it. This change removes potentially sensitive or command-injection-vulnerable arguments such as `--cmd`, `--repo-host-cmd`, and `--config` before executing the pgbackrest command. This enhances security by preventing accidental exposure of sensitive information.
hunleyd
requested changes
Nov 14, 2025
Co-authored-by: Douglas J Hunley <doug.hunley@gmail.com>
Co-authored-by: Douglas J Hunley <doug.hunley@gmail.com>
Co-authored-by: Douglas J Hunley <doug.hunley@gmail.com>
hunleyd
requested changes
Nov 14, 2025
hunleyd
requested changes
Nov 14, 2025
cuongdo
added a commit
to cuongdo/multigres
that referenced
this pull request
Nov 14, 2025
follow up for: multigres#226 (comment) Also added some of the configs from the Supabase pgBackRest config supabase/postgres#1878 Signed-off-by: Cuong Do <cuongdo@users.noreply.github.com>
cuongdo
added a commit
to multigres/multigres
that referenced
this pull request
Nov 17, 2025
* fix(multipooler): read cached copy of pooler topo follow up for: #226 (comment) Also added some of the configs from the Supabase pgBackRest config supabase/postgres#1878 Signed-off-by: Cuong Do <cuongdo@users.noreply.github.com> * Remove "Cached" from state getter functions Signed-off-by: Cuong Do <cuongdo@users.noreply.github.com> * Make restore more resilient to stale PG conns Restore wasn't handling the dead DB connections left behind by its stopping/restarting Postgres. However, this raises the question of how resilient multipooler.Executor needs to be in this situation. Signed-off-by: Cuong Do <cuongdo@users.noreply.github.com> * do not start postgres if restore fails orch should detect this and initiate fix Signed-off-by: Cuong Do <cuongdo@users.noreply.github.com> --------- Signed-off-by: Cuong Do <cuongdo@users.noreply.github.com>
Contributor
Author
|
Tested local infra with workflow ami: |
MesuterPikin
added a commit
to MesuterPikin/multigres
that referenced
this pull request
Nov 29, 2025
* fix(multipooler): read cached copy of pooler topo follow up for: multigres/multigres#226 (comment) Also added some of the configs from the Supabase pgBackRest config supabase/postgres#1878 Signed-off-by: Cuong Do <cuongdo@users.noreply.github.com> * Remove "Cached" from state getter functions Signed-off-by: Cuong Do <cuongdo@users.noreply.github.com> * Make restore more resilient to stale PG conns Restore wasn't handling the dead DB connections left behind by its stopping/restarting Postgres. However, this raises the question of how resilient multipooler.Executor needs to be in this situation. Signed-off-by: Cuong Do <cuongdo@users.noreply.github.com> * do not start postgres if restore fails orch should detect this and initiate fix Signed-off-by: Cuong Do <cuongdo@users.noreply.github.com> --------- Signed-off-by: Cuong Do <cuongdo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature- pgBackRest backup solution
What is the current behavior?
pgBackRest tasks and configs are absent
What is the new behavior?
pgBackRest tasks and configs are missing are present
Additional context
NA