Skip to content

Commit 66be201

Browse files
committed
ADjust schemas
1 parent f0b2a01 commit 66be201

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

src/superannotate_schemas/schemas/external/document.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
from superannotate_schemas.schemas.base import BaseInstance
66
from superannotate_schemas.schemas.base import BaseMetadata as Metadata
77
from superannotate_schemas.schemas.base import Tag
8+
from superannotate_schemas.schemas.base import NotEmptyStr
89

910
from superannotate_schemas.schemas.base import BaseModel
1011
from pydantic import Field
1112
from pydantic import StrictStr
12-
from pydantic import StrictInt
1313

1414

1515
class Attribute(BaseAttribute):
16-
id: StrictInt
17-
group_id: StrictInt = Field(None, alias="groupId")
16+
name: NotEmptyStr
17+
group_name: NotEmptyStr = Field(alias="groupName")
1818

1919

2020
class DocumentInstance(BaseInstance):

src/superannotate_schemas/schemas/internal/document.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from superannotate_schemas.schemas.base import BaseInstance
66
from superannotate_schemas.schemas.base import BaseMetadata as Metadata
77
from superannotate_schemas.schemas.base import Tag
8-
from superannotate_schemas.schemas.base import NotEmptyStr
8+
from superannotate_schemas.schemas.base import StrictInt
99

1010
from superannotate_schemas.schemas.base import BaseModel
1111

@@ -14,8 +14,8 @@
1414

1515

1616
class Attribute(BaseAttribute):
17-
name: NotEmptyStr
18-
group_name: NotEmptyStr = Field(alias="groupName")
17+
id: StrictInt
18+
group_id: StrictInt = Field(None, alias="groupId")
1919

2020

2121
class DocumentInstance(BaseInstance):

tests/test_validators.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,13 @@ def test_validate_document_annotation_wrong_class_id(self, mock_print):
340340
data = json.loads(f.read())
341341
validator = AnnotationValidators.get_validator("document")(data)
342342
self.assertFalse(validator.is_valid())
343-
self.assertEqual(len(validator.generate_report()), 70)
343+
# TODO adjust
344+
self.assertEqual(
345+
validator.generate_report().strip(),
346+
"""instances[0].classId integer type expected
347+
instances[0].attributes[0].name field required
348+
instances[0].attributes[0].groupName field required""".strip()
349+
)
344350

345351
def test_validate_document_annotation_with_null_created_at(self):
346352
with tempfile.TemporaryDirectory() as tmpdir_name:

0 commit comments

Comments
 (0)