-
Notifications
You must be signed in to change notification settings - Fork 2
[Feature request] HTTP request signing not supported #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jnv AWS request signing is different, this is quiet simple payload signiture, which could be done in map (if stdlib with crypto would be available). compared to https://docs.aws.amazon.com/general/latest/gr/sigv4_signing.html Unfortunately neither is them is really standardized. |
I see. Personally I would prefer if requests signing were, in general, handled as a security scheme, but I am not sure whether it is possible to generalize this across many providers. But exposing relevant crypto functions in map would cover both Binance and AWS needs - or not? |
Another case is with 2Checkout API. In this case, though, the authentication could be handled inside the map, since it doesn't work with the payload:
So what we are missing in map for this is MD5 HMAC digest. Moreover, getting the current datetime in this format will be a PITA, but it can be done with some ugly string manipulation. |
Uh oh!
There was an error while loading. Please reload this page.
Some API endpoints have secuirty from request signing e.g. wallet information on binance - https://api.binance.com/sapi/v1/capital/config/getall
Information about signed endpoint security: https://binance-docs.github.io/apidocs/spot/en/#signed-trade-user_data-and-margin-endpoint-security
Expected Behavior
Request signing should be supported
Current Behavior
Request signing is not supported
Possible Solution
Implement request signing and other common security mechanisms
The text was updated successfully, but these errors were encountered: