Skip to content

Commit 58751bb

Browse files
Get rid of using timeout in tests
1 parent 4898a91 commit 58751bb

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

test/end-to-end/emailverification.test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ describe("Email Verification", () => {
168168
rid: "emailpassword",
169169
}),
170170
});
171-
await new Promise((r) => setTimeout(r, 11000));
172171

173172
consoleLogs = [];
174173
await page.reload({ waitUntil: ["networkidle0"] });
@@ -349,7 +348,7 @@ describe("Email Verification", () => {
349348
await toggleSignInSignUp(page);
350349
await defaultSignUp(page);
351350
await logoutFromEmailVerification(page);
352-
await new Promise((r) => setTimeout(r, 1000));
351+
await waitForUrl(page, "/auth/");
353352
consoleLogs = [];
354353

355354
await Promise.all([
@@ -361,8 +360,9 @@ describe("Email Verification", () => {
361360
{ name: "password", value: "Str0ngP@ssw0rd" },
362361
]);
363362
await Promise.all([submitForm(page), page.waitForNavigation({ waitUntil: "networkidle0" })]);
364-
await new Promise((r) => setTimeout(r, 2000));
365363
await waitForUrl(page, "/auth/verify-email");
364+
await waitForSTElement(page, "[data-supertokens~='sendVerifyEmailResend']");
365+
366366
// Click on resend email should show "Email Resent" success message
367367
await sendVerifyEmail(page);
368368
await page.waitForResponse(
@@ -393,10 +393,10 @@ describe("Email Verification", () => {
393393
"ST_LOGS SESSION OVERRIDE GET_USER_ID",
394394
"ST_LOGS EMAIL_VERIFICATION OVERRIDE SEND_VERIFICATION_EMAIL",
395395
"ST_LOGS EMAIL_VERIFICATION PRE_API_HOOKS SEND_VERIFY_EMAIL",
396-
"ST_LOGS EMAIL_VERIFICATION ON_HANDLE_EVENT VERIFY_EMAIL_SENT",
397396
"ST_LOGS EMAIL_VERIFICATION OVERRIDE SEND_VERIFICATION_EMAIL",
398397
"ST_LOGS EMAIL_VERIFICATION PRE_API_HOOKS SEND_VERIFY_EMAIL",
399398
"ST_LOGS EMAIL_VERIFICATION ON_HANDLE_EVENT VERIFY_EMAIL_SENT",
399+
"ST_LOGS EMAIL_VERIFICATION ON_HANDLE_EVENT VERIFY_EMAIL_SENT",
400400
"ST_LOGS SESSION OVERRIDE SIGN_OUT",
401401
"ST_LOGS SESSION PRE_API_HOOKS SIGN_OUT",
402402
"ST_LOGS SESSION ON_HANDLE_EVENT SIGN_OUT",
@@ -408,7 +408,7 @@ describe("Email Verification", () => {
408408
await toggleSignInSignUp(page);
409409
await defaultSignUp(page);
410410
await logoutFromEmailVerification(page);
411-
await new Promise((r) => setTimeout(r, 1000));
411+
await waitForUrl(page, "/auth/");
412412
consoleLogs = [];
413413

414414
await Promise.all([
@@ -484,7 +484,7 @@ describe("Email Verification", () => {
484484
const { fieldValues, postValues } = getDefaultSignUpFieldValues();
485485
await signUp(page, fieldValues, postValues, "emailpassword");
486486
await logoutFromEmailVerification(page);
487-
await new Promise((r) => setTimeout(r, 100));
487+
await waitForUrl(page, "/auth/");
488488
consoleLogs = [];
489489

490490
// Attempt verification without a session

0 commit comments

Comments
 (0)