Skip to content

Commit be1dcc1

Browse files
fix: use twitter as twitter providers Id (#746)
* fix: use twitter as twitter providers Id * update changelog and bump version * update changelog * incorporate suggested changes * update code
1 parent 3d1cabf commit be1dcc1

File tree

7 files changed

+15
-11
lines changed

7 files changed

+15
-11
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111

1212
- Updated dev/start script in netlify example
1313

14+
## [0.35.4] - 2023-09-28
15+
16+
### Fixes
17+
18+
- fixed using `twitter` as id by default in twitter provider.
19+
1420
## [0.35.3] - 2023-09-26
1521

1622
### Added

lib/build/thirdparty-shared.js

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/build/version.d.ts

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/ts/recipe/thirdparty/providers/twitter.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,16 @@ export default class Twitter extends Provider {
3939
* Constructor.
4040
*/
4141
constructor(config?: TwitterProviderConfig) {
42-
let id = "x";
4342
let name = "X";
43+
4444
const normalisedUseLegacyTwitterLogo = config?.useLegacyTwitterLogo === true;
4545

4646
if (normalisedUseLegacyTwitterLogo) {
47-
id = "twitter";
4847
name = "Twitter";
4948
}
5049

5150
super({
52-
id,
51+
id: "twitter",
5352
name,
5453
...config,
5554
});

lib/ts/version.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
* License for the specific language governing permissions and limitations
1313
* under the License.
1414
*/
15-
export const package_version = "0.35.3";
15+
export const package_version = "0.35.4";

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "supertokens-auth-react",
3-
"version": "0.35.3",
3+
"version": "0.35.4",
44
"description": "ReactJS SDK that provides login functionality with SuperTokens.",
55
"main": "./index.js",
66
"engines": {

0 commit comments

Comments
 (0)