Merge pull request #396 from supertokens/smtp-fix

fix: smtp tls config

Author: rishabhpoddar

CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [unreleased]
 
+## [0.17.4] - 2024-02-08
+
+- Adds `TLSConfig` to SMTP settings.
+- `TLSConfig` is always passed to gomail so that it can be used when gomail uses `STARTTLS` to upgrade the connection to TLS. - https://github.com/supertokens/supertokens-golang/issues/392
+- Not setting `InsecureSkipVerify` to `true` in the SMTP settings because it is not recommended to use it in production.
+
 ## [0.17.3] - 2023-12-12
 
 - CI/CD changes

ingredients/emaildelivery/main.go

@@ -58,9 +58,13 @@ func SendSMTPEmail(settings SMTPSettings, content EmailContent) error {
 	}
 
 	d := gomail.NewDialer(settings.Host, settings.Port, username, settings.Password)
+	if settings.TLSConfig != nil {
+		d.TLSConfig = settings.TLSConfig
+	} else {
+		d.TLSConfig = &tls.Config{ServerName: settings.Host}
+	}
 
 	if settings.Secure {
-		d.TLSConfig = &tls.Config{InsecureSkipVerify: true, ServerName: settings.Host}
 		d.SSL = true
 	}
 	return d.DialAndSend(m)

ingredients/emaildelivery/smtpmodels.go

@@ -17,16 +17,19 @@
 package emaildelivery
 
 import (
+	"crypto/tls"
+
 	"github.com/supertokens/supertokens-golang/supertokens"
 )
 
 type SMTPSettings struct {
-	Host     string
-	From     SMTPFrom
-	Port     int
-	Username *string
-	Password string
-	Secure   bool
+	Host      string
+	From      SMTPFrom
+	Port      int
+	Username  *string
+	Password  string
+	Secure    bool
+	TLSConfig *tls.Config
 }
 
 type SMTPFrom struct {

supertokens/constants.go

@@ -21,7 +21,7 @@ const (
 )
 
 // VERSION current version of the lib
-const VERSION = "0.17.3"
+const VERSION = "0.17.4"
 
 var (
 	cdiSupported = []string{"3.0"}