fixed return type and added test for default validator

Author: iresharma

recipe/emailpassword/ep_userIdMapping_test.go

@@ -188,7 +188,7 @@ func TestCreateUserIdMappingUpdateEmailPassword(t *testing.T) {
 
 	newEmail := "email@example.com"
 	newPass := "newpass123"
-	updateResp, err := UpdateEmailOrPassword(externalUserId, &newEmail, &newPass)
+	updateResp, err := UpdateEmailOrPassword(externalUserId, &newEmail, &newPass, nil)
 	assert.NoError(t, err)
 	assert.NotNil(t, updateResp.OK)
 

recipe/emailpassword/epmodels/recipeInterface.go

@@ -59,5 +59,9 @@ type UpdateEmailOrPasswordResponse struct {
 	OK                          *struct{}
 	UnknownUserIdError          *struct{}
 	EmailAlreadyExistsError     *struct{}
-	PasswordPolicyViolatedError *struct{}
+	PasswordPolicyViolatedError *PasswordPolicyViolatedError
+}
+
+type PasswordPolicyViolatedError struct {
+	FailureReason *string
 }

recipe/emailpassword/recipeImplementation.go

@@ -16,7 +16,6 @@
 package emailpassword
 
 import (
-	"errors"
 	"github.com/supertokens/supertokens-golang/recipe/emailpassword/epmodels"
 	"github.com/supertokens/supertokens-golang/supertokens"
 )
@@ -171,9 +170,12 @@ func MakeRecipeImplementation(querier supertokens.Querier, getEmailPasswordConfi
 				formFields := getEmailPasswordConfig().SignUpFeature.FormFields
 				for i := range formFields {
 					if formFields[i].ID == "password" {
-						err := formFields[i].Validate(password)
-						if err == nil {
-							return epmodels.UpdateEmailOrPasswordResponse{PasswordPolicyViolatedError: &struct{}{}}, errors.New(*err)
+						err := formFields[i].Validate(*password)
+						if err != nil {
+							errResponse := epmodels.PasswordPolicyViolatedError{
+								FailureReason: err,
+							}
+							return epmodels.UpdateEmailOrPasswordResponse{PasswordPolicyViolatedError: &errResponse}, nil
 						}
 					}
 				}

recipe/emailpassword/updateEmailPass_test.go

@@ -98,10 +98,9 @@ func TestUpdateEmailPass(t *testing.T) {
 	}
 
 	email := "test2@gmail.com"
-	password := "testPass"
+	password := "testPass1"
 
 	UpdateEmailOrPassword(data["user"].(map[string]interface{})["id"].(string), &email, &password, nil)
-
 	res1, err := unittesting.SignInRequest("testrandom@gmail.com", "validpass123", testServer.URL)
 
 	if err != nil {
@@ -140,6 +139,12 @@ func TestUpdateEmailPass(t *testing.T) {
 
 	assert.Equal(t, "OK", data2["status"])
 	assert.Equal(t, email, data2["user"].(map[string]interface{})["email"])
+
+	password = "test"
+	applyPasswordPolicy := true
+	res3, err := UpdateEmailOrPassword(data["user"].(map[string]interface{})["id"].(string), &email, &password, &applyPasswordPolicy)
+	assert.NotNil(t, res3.PasswordPolicyViolatedError)
+	assert.Equal(t, "Password must contain at least 8 characters, including a number", *res3.PasswordPolicyViolatedError.FailureReason)
 }
 
 func TestAPICustomResponse(t *testing.T) {