Skip to content

Commit cb6de2d

Browse files
committed
chore: updating fix comment
1 parent 31b03e0 commit cb6de2d

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

recipe/thirdparty/providers/apple.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,10 @@ func verifyAndGetClaimsAppleIdToken(idToken string, clientId string) (jwt.MapCla
179179

180180
// Create the keyfunc options. Refresh the JWKS every hour and log errors.
181181
options := keyfunc.Options{
182-
// RefreshInterval: time.Hour, // This causes a leak as the pointer to JWKS would be held in the goroutine
182+
// https://github.com/supertokens/supertokens-golang/issues/155
183+
// This causes a leak as the pointer to JWKS would be held in the goroutine and
184+
// also results in compounding refresh requests
185+
// RefreshInterval: time.Hour,
183186
}
184187

185188
// Create the JWKS from the resource at the given URL.

recipe/thirdparty/providers/googleWorkspaces.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,10 @@ func verifyAndGetClaims(idToken string, clientId string) (jwt.MapClaims, error)
141141

142142
// Create the keyfunc options. Refresh the JWKS every hour and log errors.
143143
options := keyfunc.Options{
144-
// RefreshInterval: time.Hour, // This causes a leak as the pointer to JWKS would be held in the goroutine
144+
// https://github.com/supertokens/supertokens-golang/issues/155
145+
// This causes a leak as the pointer to JWKS would be held in the goroutine and
146+
// also results in compounding refresh requests
147+
// RefreshInterval: time.Hour,
145148
}
146149

147150
// Create the JWKS from the resource at the given URL.

0 commit comments

Comments
 (0)