Merge pull request #336 from supertokens/session-test-fix

fix: jwks test

Author: rishabhpoddar

recipe/session/recipeImplementation.go

@@ -63,7 +63,7 @@ func getJWKSFromCacheIfPresent() *sessmodels.GetJWKSResult {
 		// from the cores again after the entry in the cache is expired
 		if (currentTime - jwksCache.LastFetched) < JWKCacheMaxAgeInMs {
 			if supertokens.IsRunningInTestMode() {
-				returnedFromCache = true
+				returnedFromCache <- true
 			}
 
 			return jwksCache
@@ -116,7 +116,7 @@ func getJWKS() (*keyfunc.JWKS, error) {
 			jwksCache = &jwksResult
 
 			if supertokens.IsRunningInTestMode() {
-				returnedFromCache = false
+				returnedFromCache <- false
 			}
 
 			return jwksResult.JWKS, nil

recipe/session/session_test.go

@@ -1973,6 +1973,7 @@ func TestThatLockingForJWKSCacheWorksFine(t *testing.T) {
 	if err != nil {
 		t.Error(err.Error())
 	}
+	<-returnedFromCache // this value must be ignored
 
 	for _, k := range jwks.KIDs() {
 		keys = append(keys, k)
@@ -1989,7 +1990,7 @@ func TestThatLockingForJWKSCacheWorksFine(t *testing.T) {
 
 	for i := 0; i < threadCount; i++ {
 		go jwksLockTestRoutine(t, &shouldStop, i, &wg, func(_keys []string) {
-			if returnedFromCache == false {
+			if <-returnedFromCache == false {
 				notReturnFromCacheCount++
 			}
 

recipe/session/testingUtils.go

@@ -24,14 +24,14 @@ import (
 
 // Testing constants
 var didGetSessionCallCore = false
-var returnedFromCache = false
+var returnedFromCache chan bool
 var urlsAttemptedForJWKSFetch []string
 
 func resetAll() {
 	supertokens.ResetForTest()
 	ResetForTest()
 	didGetSessionCallCore = false
-	returnedFromCache = false
+	returnedFromCache = make(chan bool, 1000)
 	urlsAttemptedForJWKSFetch = []string{}
 	jwksCache = nil
 }