ci: adds new workflow for checking tests passing (#37)

* ci: adds new workflow

* fixes tests

Co-authored-by: Rishabh <rishabh@supertokens.io>

Author: rishabhpoddar

.github/helpers/.gitignore

@@ -0,0 +1,2 @@
+node_modules
+package-lock.json

.github/helpers/package.json

@@ -0,0 +1,14 @@
+{
+    "name": "helpers",
+    "version": "1.0.0",
+    "description": "",
+    "main": "test-pass-check-pr.js",
+    "scripts": {
+        "test": "echo \"Error: no test specified\" && exit 1"
+    },
+    "author": "",
+    "license": "ISC",
+    "dependencies": {
+        "github-workflow-helpers": "github:supertokens/github-workflow-helpers"
+    }
+}

.github/workflows/tests-pass-check-pr.yml

@@ -0,0 +1,24 @@
+name: "Check if \"Run tests\" action succeeded"
+
+on:
+    pull_request:
+        types:
+            - opened
+            - reopened
+            - edited
+            - synchronize
+
+jobs:
+    pr-run-test-action:
+        name: Check if "Run tests" action succeeded
+        timeout-minutes: 60
+        concurrency:
+          group: ${{ github.head_ref }}
+          cancel-in-progress: true
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@v2
+            - name: node install
+              run: cd ./.github/helpers && npm i
+            - name: Calling github API
+              run: cd ./.github/helpers && GITHUB_TOKEN=${{ github.token }} REPO=${{ github.repository }} RUN_ID=${{ github.run_id }} BRANCH=${{ github.head_ref }} JOB_ID=${{ github.job }} SOURCE_OWNER=${{ github.event.pull_request.head.repo.owner.login }} CURRENT_SHA=${{ github.event.pull_request.head.sha }} node node_modules/github-workflow-helpers/test-pass-check-pr.js

build.gradle

@@ -52,6 +52,12 @@ dependencies {
     testImplementation group: 'com.google.code.gson', name: 'gson', version: '2.3.1'
 
     testImplementation 'com.tngtech.archunit:archunit-junit4:0.22.0'
+
+    // https://mvnrepository.com/artifact/com.fasterxml.jackson.dataformat/jackson-dataformat-yaml
+    testImplementation group: 'com.fasterxml.jackson.dataformat', name: 'jackson-dataformat-yaml', version: '2.10.0'
+
+    // https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-core
+    testImplementation group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.10.0'
 }
 
 jar {

src/test/java/io/supertokens/storage/postgresql/test/ConfigTest.java

@@ -17,6 +17,8 @@
 
 package io.supertokens.storage.postgresql.test;
 
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
 import com.google.gson.JsonObject;
 import io.supertokens.ProcessState;
 import io.supertokens.session.Session;
@@ -34,6 +36,7 @@
 import org.junit.rules.TestRule;
 
 import java.io.File;
+import java.io.IOException;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
@@ -318,10 +321,14 @@ public void testAddingSchemaWorks() throws Exception {
 
     @Test
     public void testValidConnectionURI() throws Exception {
+        final ObjectMapper mapper = new ObjectMapper(new YAMLFactory());
+        PostgreSQLConfig userConfig = mapper.readValue(new File("../config.yaml"), PostgreSQLConfig.class);
+        String hostname = userConfig.getHostName();
         {
             String[] args = { "../" };
 
-            Utils.setValueInConfig("postgresql_connection_uri", "postgresql://root:root@localhost:5432/supertokens");
+            Utils.setValueInConfig("postgresql_connection_uri",
+                    "postgresql://root:root@" + hostname + ":5432/supertokens");
             Utils.commentConfigValue("postgresql_password");
             Utils.commentConfigValue("postgresql_user");
             Utils.commentConfigValue("postgresql_port");
@@ -341,7 +348,7 @@ public void testValidConnectionURI() throws Exception {
             Utils.reset();
             String[] args = { "../" };
 
-            Utils.setValueInConfig("postgresql_connection_uri", "postgresql://root:root@localhost/supertokens");
+            Utils.setValueInConfig("postgresql_connection_uri", "postgresql://root:root@" + hostname + "/supertokens");
             Utils.commentConfigValue("postgresql_password");
             Utils.commentConfigValue("postgresql_user");
             Utils.commentConfigValue("postgresql_port");
@@ -361,7 +368,7 @@ public void testValidConnectionURI() throws Exception {
             Utils.reset();
             String[] args = { "../" };
 
-            Utils.setValueInConfig("postgresql_connection_uri", "postgresql://localhost:5432/supertokens");
+            Utils.setValueInConfig("postgresql_connection_uri", "postgresql://" + hostname + ":5432/supertokens");
             Utils.commentConfigValue("postgresql_port");
             Utils.commentConfigValue("postgresql_host");
             Utils.commentConfigValue("postgresql_database_name");
@@ -379,7 +386,7 @@ public void testValidConnectionURI() throws Exception {
             Utils.reset();
             String[] args = { "../" };
 
-            Utils.setValueInConfig("postgresql_connection_uri", "postgresql://root@localhost:5432/supertokens");
+            Utils.setValueInConfig("postgresql_connection_uri", "postgresql://root@" + hostname + ":5432/supertokens");
             Utils.commentConfigValue("postgresql_user");
             Utils.commentConfigValue("postgresql_port");
             Utils.commentConfigValue("postgresql_host");
@@ -398,7 +405,7 @@ public void testValidConnectionURI() throws Exception {
             Utils.reset();
             String[] args = { "../" };
 
-            Utils.setValueInConfig("postgresql_connection_uri", "postgresql://root:root@localhost:5432");
+            Utils.setValueInConfig("postgresql_connection_uri", "postgresql://root:root@" + hostname + ":5432");
             Utils.commentConfigValue("postgresql_password");
             Utils.commentConfigValue("postgresql_user");
             Utils.commentConfigValue("postgresql_port");
@@ -417,6 +424,9 @@ public void testValidConnectionURI() throws Exception {
 
     @Test
     public void testInvalidConnectionURI() throws Exception {
+        final ObjectMapper mapper = new ObjectMapper(new YAMLFactory());
+        PostgreSQLConfig userConfig = mapper.readValue(new File("../config.yaml"), PostgreSQLConfig.class);
+        String hostname = userConfig.getHostName();
         {
             String[] args = { "../" };
 
@@ -439,7 +449,7 @@ public void testInvalidConnectionURI() throws Exception {
             String[] args = { "../" };
 
             Utils.setValueInConfig("postgresql_connection_uri",
-                    "postgresql://root:wrongPassword@localhost:5432/supertokens");
+                    "postgresql://root:wrongPassword@" + hostname + ":5432/supertokens");
             Utils.commentConfigValue("postgresql_password");
             Utils.commentConfigValue("postgresql_user");
             Utils.commentConfigValue("postgresql_port");
@@ -459,11 +469,14 @@ public void testInvalidConnectionURI() throws Exception {
 
     @Test
     public void testValidConnectionURIAttributes() throws Exception {
+        final ObjectMapper mapper = new ObjectMapper(new YAMLFactory());
+        PostgreSQLConfig userConfig = mapper.readValue(new File("../config.yaml"), PostgreSQLConfig.class);
+        String hostname = userConfig.getHostName();
         {
             String[] args = { "../" };
 
             Utils.setValueInConfig("postgresql_connection_uri",
-                    "postgresql://root:root@localhost:5432/supertokens?key1=value1");
+                    "postgresql://root:root@" + hostname + ":5432/supertokens?key1=value1");
 
             TestingProcessManager.TestingProcess process = TestingProcessManager.start(args);
             assertNotNull(process.checkOrWaitForEvent(ProcessState.PROCESS_STATE.STARTED));
@@ -478,9 +491,8 @@ public void testValidConnectionURIAttributes() throws Exception {
             Utils.reset();
             String[] args = { "../" };
 
-            Utils.setValueInConfig("postgresql_connection_uri",
-                    "postgresql://root:root@localhost:5432/supertokens?key1=value1&allowPublicKeyRetrieval=false&key2"
-                            + "=value2");
+            Utils.setValueInConfig("postgresql_connection_uri", "postgresql://root:root@" + hostname
+                    + ":5432/supertokens?key1=value1&allowPublicKeyRetrieval=false&key2" + "=value2");
 
             TestingProcessManager.TestingProcess process = TestingProcessManager.start(args);
             assertNotNull(process.checkOrWaitForEvent(ProcessState.PROCESS_STATE.STARTED));
@@ -492,14 +504,17 @@ public void testValidConnectionURIAttributes() throws Exception {
         }
     }
 
-    public static void checkConfig(PostgreSQLConfig config) {
+    public static void checkConfig(PostgreSQLConfig config) throws IOException {
+        final ObjectMapper mapper = new ObjectMapper(new YAMLFactory());
+        PostgreSQLConfig userConfig = mapper.readValue(new File("../config.yaml"), PostgreSQLConfig.class);
+        String hostname = userConfig.getHostName();
         assertEquals("Config getAttributes did not match default", config.getConnectionAttributes(),
                 "allowPublicKeyRetrieval=true");
         assertEquals("Config getSchema did not match default", config.getConnectionScheme(), "postgresql");
         assertEquals("Config connectionPoolSize did not match default", config.getConnectionPoolSize(), 10);
         assertEquals("Config databaseName does not match default", config.getDatabaseName(), "supertokens");
         assertEquals("Config keyValue table does not match default", config.getKeyValueTable(), "key_value");
-        assertEquals("Config hostName does not match default ", config.getHostName(), "localhost");
+        assertEquals("Config hostName does not match default ", config.getHostName(), hostname);
         assertEquals("Config port does not match default", config.getPort(), 5432);
         assertEquals("Config sessionInfoTable does not match default", config.getSessionInfoTable(), "session_info");
         assertEquals("Config user does not match default", config.getUser(), "root");