refactor: use @typescript-eslint/types instead of estree (#294)

* refactor: use `@typescript-eslint/types` instead of `estree`

* fix: type cov

* fix: type cov

Author: ota-meshi

package.json

@@ -34,7 +34,7 @@
     "docs:build": "yarn svelte-kit build",
     "docs:preview": "yarn svelte-kit preview",
     "docs:watch": "yarn svelte-kit dev",
-    "format-for-gen-file": "eslint src/types-for-node.ts src/utils/rules.ts src/configs --fix",
+    "format-for-gen-file": "eslint src/types-for-node.ts src/utils/rules.ts src/configs typings/estree/index.d.ts --fix",
     "install-with-ignore-engines": "yarn --ignore-engines",
     "lint": "run-p lint:*",
     "lint-fix": "yarn lint:es --fix && yarn lint:style --fix",
@@ -100,7 +100,6 @@
     "@types/eslint-scope": "^3.7.0",
     "@types/eslint-utils": "^3.0.1",
     "@types/eslint-visitor-keys": "^1.0.0",
-    "@types/estree": "^1.0.0",
     "@types/esutils": "^2.0.0",
     "@types/less": "^3.0.3",
     "@types/markdown-it": "^12.2.3",

src/rules/@typescript-eslint/no-unnecessary-condition.ts

@@ -3,7 +3,6 @@
 // https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/no-unnecessary-condition.ts
 import type { TSESTree } from "@typescript-eslint/types"
 import type { AST } from "svelte-eslint-parser"
-import type * as ESTree from "estree"
 import { createRule } from "../../utils"
 import {
   isFalsyType,
@@ -183,7 +182,7 @@ export default createRule("@typescript-eslint/no-unnecessary-condition", {
       })
     }
 
-    const mutableVarReferenceIds: ESTree.Identifier[] = []
+    const mutableVarReferenceIds: TSESTree.Identifier[] = []
     const scriptElements: AST.SvelteScriptElement[] = []
     let inSvelteReactiveStatement = false
 
@@ -238,7 +237,7 @@ export default createRule("@typescript-eslint/no-unnecessary-condition", {
       }
 
       return mutableVarReferenceIds.some(
-        (id) => node.range[0] <= id.range![0] && id.range![1] <= node.range[1],
+        (id) => node.range[0] <= id.range[0] && id.range[1] <= node.range[1],
       )
     }
 

src/rules/derived-has-same-inputs-outputs.ts

@@ -1,4 +1,4 @@
-import type * as ESTree from "estree"
+import type { TSESTree } from "@typescript-eslint/types"
 import { createRule } from "../utils"
 import type { RuleContext } from "../types"
 import { extractStoreReferences } from "./reference-helpers/svelte-store"
@@ -21,18 +21,18 @@ export default createRule("derived-has-same-inputs-outputs", {
   create(context) {
     /** check node type */
     function isIdentifierOrArrayExpression(
-      node: ESTree.SpreadElement | ESTree.Expression,
-    ): node is ESTree.Identifier | ESTree.ArrayExpression {
+      node: TSESTree.SpreadElement | TSESTree.Expression,
+    ): node is TSESTree.Identifier | TSESTree.ArrayExpression {
       return ["Identifier", "ArrayExpression"].includes(node.type)
     }
 
     type ArrowFunctionExpressionOrFunctionExpression =
-      | ESTree.ArrowFunctionExpression
-      | ESTree.FunctionExpression
+      | TSESTree.ArrowFunctionExpression
+      | TSESTree.FunctionExpression
 
     /** check node type */
     function isFunctionExpression(
-      node: ESTree.SpreadElement | ESTree.Expression,
+      node: TSESTree.SpreadElement | TSESTree.Expression,
     ): node is ArrowFunctionExpressionOrFunctionExpression {
       return ["ArrowFunctionExpression", "FunctionExpression"].includes(
         node.type,
@@ -45,7 +45,7 @@ export default createRule("derived-has-same-inputs-outputs", {
      */
     function checkIdentifier(
       context: RuleContext,
-      args: ESTree.Identifier,
+      args: TSESTree.Identifier,
       fn: ArrowFunctionExpressionOrFunctionExpression,
     ) {
       const fnParam = fn.params[0]
@@ -54,7 +54,7 @@ export default createRule("derived-has-same-inputs-outputs", {
       if (expectedName !== fnParam.name) {
         context.report({
           node: fn,
-          loc: fnParam.loc!,
+          loc: fnParam.loc,
           messageId: "unexpected",
           data: { name: expectedName },
         })
@@ -67,7 +67,7 @@ export default createRule("derived-has-same-inputs-outputs", {
      */
     function checkArrayExpression(
       context: RuleContext,
-      args: ESTree.ArrayExpression,
+      args: TSESTree.ArrayExpression,
       fn: ArrowFunctionExpressionOrFunctionExpression,
     ) {
       const fnParam = fn.params[0]
@@ -82,7 +82,7 @@ export default createRule("derived-has-same-inputs-outputs", {
           if (expectedName !== element.name) {
             context.report({
               node: fn,
-              loc: element.loc!,
+              loc: element.loc,
               messageId: "unexpected",
               data: { name: expectedName },
             })

src/rules/first-attribute-linebreak.ts

@@ -68,13 +68,11 @@ export default createRule("first-attribute-linebreak", {
             : multiline
 
         if (location === "beside") {
-          if (
-            node.parent.name.loc!.end.line === firstAttribute.loc.start.line
-          ) {
+          if (node.parent.name.loc.end.line === firstAttribute.loc.start.line) {
             return
           }
         } else {
-          if (node.parent.name.loc!.end.line < firstAttribute.loc.start.line) {
+          if (node.parent.name.loc.end.line < firstAttribute.loc.start.line) {
             return
           }
         }

src/rules/indent-helpers/ast.ts

@@ -1,11 +1,11 @@
 import type { AST } from "svelte-eslint-parser"
-import type * as ESTree from "estree"
+import type { TSESTree } from "@typescript-eslint/types"
 type AnyToken = AST.Token | AST.Comment
 /**
  * Check whether the given token is a whitespace.
  */
 export function isWhitespace(
-  token: AnyToken | ESTree.Comment | null | undefined,
+  token: AnyToken | TSESTree.Comment | null | undefined,
 ): boolean {
   return (
     token != null &&
@@ -18,7 +18,7 @@ export function isWhitespace(
  * Check whether the given token is a not whitespace.
  */
 export function isNotWhitespace(
-  token: AnyToken | ESTree.Comment | null | undefined,
+  token: AnyToken | TSESTree.Comment | null | undefined,
 ): boolean {
   return (
     token != null &&

src/rules/indent-helpers/commons.ts

@@ -74,7 +74,7 @@ export function isBeginningOfLine(
     filter: isNotWhitespace,
   })
 
-  return !prevToken || prevToken.loc.end.line < node.loc!.start.line
+  return !prevToken || prevToken.loc.end.line < node.loc.start.line
 }
 
 /**