Merge pull request #23 from merceyz/merceyz/dollar-signs

rixo · web-flow · commit e449fb8a2a0a · 2021-01-17T00:17:19.000+01:00
fix: handle paths with dollar signs
diff --git a/lib/make-hot.js b/lib/make-hot.js
@@ -429,7 +429,9 @@ const createMakeHot = ({ walk, meta = 'import.meta', hotApi, adapter }) => {
       acceptable: isAcceptable(hotOptions, compileOptions, compiled),
     })
 
-    return compiledCode.replace(/(\n?export default ([^;]*);)/, replacement)
+    return compiledCode.replace(/(\n?export default ([^;]*);)/, (match, $1, $2) => {
+      return replacement.replace(/\$2/g, () => $2)
+    })
   }
 
   // rollup-plugin-svelte-hot needs hotApi path (for tests)

Original file line number	Diff line number	Diff line change
`@@ -429,7 +429,9 @@ const createMakeHot = ({ walk, meta = 'import.meta', hotApi, adapter }) => {`
`429`	`429`	`acceptable: isAcceptable(hotOptions, compileOptions, compiled),`
`430`	`430`	`})`
`431`	`431`
`432`		`- return compiledCode.replace(/(\n?export default ([^;]*);)/, replacement)`
	`432`	`+ return compiledCode.replace(/(\n?export default ([^;]*);)/, (match, $1, $2) => {`
	`433`	`+ return replacement.replace(/\$2/g, () => $2)`
	`434`	`+ })`
`433`	`435`	`}`
`434`	`436`
`435`	`437`	`// rollup-plugin-svelte-hot needs hotApi path (for tests)`