Merge pull request #63 from sveltejs/fix/support-css-external

rixo · web-flow · commit e6c426248a54 · 2022-11-14T22:12:14.000+01:00
fix: support new 'external' value for compileOptions.css introduced in svelte 3.53.0
diff --git a/.changeset/few-cycles-cry.md b/.changeset/few-cycles-cry.md
@@ -0,0 +1,5 @@
+---
+'svelte-hmr': patch
+---
+
+support 'external' as value for compileOptions.css
diff --git a/package.json b/package.json
@@ -17,6 +17,7 @@
   },
   "pnpm": {
     "overrides": {
+      "minimatch@^3.0.4": "^3.1.2",
       "svelte-hmr": "workspace:*"
     },
     "peerDependencyRules": {
diff --git a/packages/svelte-hmr/lib/make-hot.js b/packages/svelte-hmr/lib/make-hot.js
@@ -444,7 +444,9 @@ const createMakeHot = ({ resolveAbsoluteImport, pkg = {} }) => ({
 
     const { importAdapterName, injectCss } = hotOptions
 
-    const emitCss = compileOptions && compileOptions.css === false
+    const emitCss =
+      compileOptions &&
+      (compileOptions.css === false || compileOptions.css === 'external')
 
     const preserveLocalState = resolvePreserveLocalState({
       hotOptions,
diff --git a/playground/kit-app/package.json b/playground/kit-app/package.json
@@ -7,8 +7,8 @@
 		"@fontsource/fira-mono": "^4.5.0"
 	},
 	"devDependencies": {
-		"@sveltejs/adapter-auto": "next",
-		"@sveltejs/kit": "next",
+		"@sveltejs/adapter-auto": "^1.0.0-next.75",
+		"@sveltejs/kit": "^1.0.0-next.483",
 		"@types/cookie": "^0.5.1",
 		"svelte": "^3.50.1",
 		"svelte-check": "^2.7.1",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte-hmr': patch
 +---
++
 +support 'external' as value for compileOptions.css