remove support for spreading objects

Author: jackgdll

packages/svelte/src/compiler/phases/2-analyze/index.js

@@ -714,7 +714,9 @@ export function analyze_component(root, source, options) {
 							if (
 								type === 'FunctionDeclaration' ||
 								type === 'FunctionExpression' ||
-								type === 'ArrowFunctionExpression'
+								type === 'ArrowFunctionExpression' ||
+								(type === 'BindDirective' &&
+									/** @type {AST.BindDirective} */ (path[i]).metadata.spread_binding)
 							) {
 								continue inner;
 							}

packages/svelte/src/compiler/phases/3-transform/shared/spread_bindings.js

@@ -12,28 +12,32 @@ import { dev, source } from '../../../state.js';
  */
 export function init_spread_bindings(spread_expression, { state, visit }) {
 	const expression = /** @type {Expression} */ (visit(spread_expression));
-	const expression_text = dev
-		? b.literal(source.slice(spread_expression.start, spread_expression.end))
-		: undefined;
+	const expression_text = b.literal(source.slice(spread_expression.start, spread_expression.end));
 
 	const id = b.id(state.scope.generate('$$spread_binding'));
 	state.init.push(
 		b.const(
 			id,
 			b.call(
 				'$.derived',
-				b.thunk(b.call('$.validate_spread_bindings', expression, expression_text))
+				b.thunk(
+					dev ? b.call('$.validate_spread_bindings', expression, expression_text) : expression
+				)
 			)
 		)
 	);
 
 	const is_server = state.options.generate === 'server';
 	const binding = is_server ? b.call(id) : b.call('$.get', id);
 
-	const get = b.thunk(b.call(b.member(binding, b.literal(0), true)));
+	const get = b.thunk(
+		b.call(b.logical('??', b.member(binding, b.literal(0), true), b.id('$.noop')))
+	);
+
 	const set = b.arrow(
 		[b.id('$$value')],
-		b.call(b.member(binding, b.literal(1), true), b.id('$$value'))
+		b.call(b.logical('??', b.member(binding, b.literal(1), true), b.id('$.noop')), b.id('$$value'))
 	);
+
 	return { get, set };
 }

packages/svelte/src/internal/server/index.js

@@ -511,7 +511,7 @@ export { assign_payload, copy_payload } from './payload.js';
 
 export { snapshot } from '../shared/clone.js';
 
-export { fallback, to_array } from '../shared/utils.js';
+export { noop, fallback, to_array } from '../shared/utils.js';
 
 export {
 	invalid_default_snippet,

packages/svelte/src/internal/shared/validate.js

@@ -53,16 +53,15 @@ export function prevent_snippet_stringification(fn) {
  * @return {[() => unknown, (value: unknown) => void]}
  */
 export function validate_spread_bindings(spread_object, name) {
-	const is_array = Array.isArray(spread_object);
-	const getter = is_array ? spread_object[0] : spread_object.get;
-	const setter = is_array ? spread_object[1] : spread_object.set;
+	const getter = spread_object[0];
+	const setter = spread_object[1];
 
 	if (typeof getter !== 'function' && getter != null) {
-		e.invalid_spread_bindings(name + (is_array ? '[0]' : '.get'));
+		e.invalid_spread_bindings(name + '[0]');
 	}
 	if (typeof setter !== 'function' && setter != null) {
-		e.invalid_spread_bindings(name + (is_array ? '[1]' : '.set'));
+		e.invalid_spread_bindings(name + '[1]');
 	}
 
-	return [getter ?? noop, setter ?? noop];
+	return [getter, setter];
 }

packages/svelte/tests/runtime-runes/samples/bind-spread-component/Child.svelte

@@ -1,13 +1,13 @@
 <script>
 	let { a = $bindable() } = $props();
 
-	const bindings = $derived([
+	const bindings = [
 		() => a,
 		(v) => {
 			console.log('b', v);
 			a = v;
 		}
-	]);
+	];
 </script>
 
 <input

packages/svelte/tests/runtime-runes/samples/bind-spread-component/_config.js

@@ -1,6 +1,5 @@
 import { flushSync } from 'svelte';
 import { test } from '../../test';
-import { assert_ok } from '../../../suite';
 
 export default test({
 	async test({ assert, target, logs }) {

packages/svelte/tests/runtime-runes/samples/bind-spread-empty/main.svelte

@@ -1,37 +1,15 @@
 <script>
-  const empty_bindings_array = []
-  const empty_bindings_object = {}
-  const incompatible_bindings_object = {
-		read() {
-			console.log('read');
-			return true;
-		},
-		write(v) {
-			console.log('write', v);
-		}
-	}
-	const undefined_bindings_array = [undefined, undefined];
-	const undefined_bindings_object = { get: undefined, set: undefined };
-	const null_bindings_array = [null, null];
-	const null_bindings_object = { get: null, set: null };
-
 	function onchange(event) {
 		console.log('change', event.currentTarget.checked);
 	}
 </script>
 
 <input type="checkbox" {onchange} />
 
-<input type="checkbox" bind:checked={...empty_bindings_array} {onchange} />
-
-<input type="checkbox" bind:checked={...empty_bindings_object} {onchange} />
-
-<input type="checkbox" bind:checked={...incompatible_bindings_object} {onchange} />
-
-<input type="checkbox" bind:checked={...undefined_bindings_array} {onchange} />
+<input type="checkbox" bind:checked={...[]} {onchange} />
 
-<input type="checkbox" bind:checked={...undefined_bindings_object} {onchange} />
+<input type="checkbox" bind:checked={...[undefined, undefined]} {onchange} />
 
-<input type="checkbox" bind:checked={...null_bindings_array} {onchange} />
+<input type="checkbox" bind:checked={...[null, null]} {onchange} />
 
-<input type="checkbox" bind:checked={...null_bindings_object} {onchange} />
+<input type="checkbox" bind:checked={...{}} {onchange} />

packages/svelte/tests/runtime-runes/samples/bind-spread-error/main.svelte

@@ -1,7 +1 @@
-<script>
-	function getInvalidBindings() {
-		return { get: 'not a function', set: 'not a function' };
-	}
-</script>
-
-<input type="checkbox" bind:checked={...getInvalidBindings()} />
+<input type="checkbox" bind:checked={...['not a function', 'not a function' ]} />

packages/svelte/tests/runtime-runes/samples/bind-spread/_config.js

@@ -11,11 +11,7 @@ export default test({
 
 		checkboxes.forEach((checkbox) => checkbox.click());
 
-		assert.deepEqual(logs, [
-			'getArrayBindings',
-			'getObjectBindings',
-			...repeatArray(checkboxes.length, ['check', false])
-		]);
+		assert.deepEqual(logs, ['getBindings', ...repeatArray(checkboxes.length, ['check', false])]);
 	}
 });
 

packages/svelte/tests/runtime-runes/samples/bind-spread/main.svelte

@@ -7,19 +7,16 @@
 		check = v;
 	};
 	const bindings = [get, set];
-	const nested = {deep: {
-		bindings: [get, set],}
+	const nested = {
+		deep: {
+			bindings: [get, set],
+		},
 	};
 
-	function getArrayBindings() {
-		console.log('getArrayBindings');
+	function getBindings() {
+		console.log('getBindings');
 		return [get, set];
 	}
-
-	function getObjectBindings() {
-		console.log('getObjectBindings');
-		return { get, set };
-	}
 </script>
 
 <input type="checkbox" bind:checked={get, set} />
@@ -28,8 +25,6 @@
 
 <input type="checkbox" bind:checked={...nested.deep.bindings} />
 
-<input type="checkbox" bind:checked={...getArrayBindings()} />
+<input type="checkbox" bind:checked={...getBindings()} />
 
 <input type="checkbox" bind:checked={...(() => [get, set])()} />
-
-<input type="checkbox" bind:checked={...getObjectBindings()} />