Skip to content

Commit 5844d91

Browse files
committed
Remove redundant nextTick
1 parent 954b484 commit 5844d91

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

tests/unit/components/AdjustableSidebarWidth.spec.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,6 @@ describe('AdjustableSidebarWidth', () => {
621621
}],
622622
}));
623623
await wrapper.vm.$nextTick();
624-
await flushPromises();
625624
expect(store.state.contentWidth).toBe(99);
626625
});
627626

tests/unit/components/Filter/FilterInput.spec.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ describe('FilterInput', () => {
107107
it('renders focus class if showSuggestedTags is true and border style is not prevented', async () => {
108108
await wrapper.setData({ showSuggestedTags: true });
109109
await wrapper.setProps({ preventBorderStyle: false });
110-
await wrapper.vm.$nextTick();
111110

112111
expect(wrapper.findComponent('.filter.focus').exists()).toBe(true);
113112
});
@@ -143,7 +142,6 @@ describe('FilterInput', () => {
143142

144143
it('renders an filter label element that has a input-value attrib to resize the input', async () => {
145144
await wrapper.setProps({ value: inputValue });
146-
await wrapper.vm.$nextTick();
147145
const filterLabel = wrapper.findComponent('#filter-label');
148146
// check input-value attrib for filter label contains the input value
149147
expect(filterLabel.attributes('data-value')).toBe(inputValue);
@@ -158,7 +156,6 @@ describe('FilterInput', () => {
158156

159157
// simulate the `handleScrollbar` mixin triggering ON
160158
await wrapper.setData({ isScrolling: true });
161-
await wrapper.vm.$nextTick();
162159

163160
expect(inputBoxWrapper.classes('scrolling')).toBe(true);
164161
});
@@ -728,7 +725,6 @@ describe('FilterInput', () => {
728725
await wrapper.vm.$nextTick();
729726

730727
await wrapper.setProps({ selectedTags: [selectedTag] });
731-
await wrapper.vm.$nextTick();
732728
selectedTagsComponent = wrapper.findComponent({ ref: 'selectedTags' });
733729
});
734730

@@ -768,7 +764,6 @@ describe('FilterInput', () => {
768764
document.activeElement.blur();
769765
await wrapper.vm.$nextTick();
770766
await wrapper.setProps({ selectedTags: [] });
771-
await wrapper.vm.$nextTick();
772767
expect(document.activeElement).not.toEqual(input.element);
773768
});
774769

@@ -923,7 +918,6 @@ describe('FilterInput', () => {
923918
it('deletes selected tag when tag is clicked on a virtual keyboard', async () => {
924919
await wrapper.setData({ keyboardIsVirtual: true });
925920
await wrapper.setProps({ selectedTags: [selectedTag, 'Tag2'] });
926-
await wrapper.vm.$nextTick();
927921

928922
selectedTagsComponent.vm.$emit('click-tags', { tagName: 'Tag2' });
929923
await flushPromises();
@@ -952,7 +946,6 @@ describe('FilterInput', () => {
952946

953947
it('resets filters when `deleteButton` is clicked', async () => {
954948
await wrapper.setProps({ value: '', selectedTags: [] });
955-
await wrapper.vm.$nextTick();
956949
const deleteBtn = wrapper.findComponent('.filter__delete-button');
957950
deleteBtn.trigger('click');
958951

@@ -1148,7 +1141,6 @@ describe('FilterInput', () => {
11481141

11491142
it('assigns selected tags to active tags when cmd + a is triggered on input', async () => {
11501143
await wrapper.setProps({ value: 'Foo', selectedTags: tags });
1151-
await wrapper.vm.$nextTick();
11521144
const selectedTagsComponent = wrapper.findComponent({ ref: 'selectedTags' });
11531145
wrapper.findComponent('input').trigger('keydown', {
11541146
key: 'a',
@@ -1424,7 +1416,6 @@ describe('FilterInput', () => {
14241416
beforeEach(async () => {
14251417
jest.resetAllMocks();
14261418
await wrapper.setProps({ selectedTags });
1427-
await wrapper.vm.$nextTick();
14281419
selectedTagsComponent = wrapper.findComponent({ ref: 'selectedTags' });
14291420
spyFocusTag = jest.spyOn(selectedTagsComponent.vm, 'focusTag').mockReturnValueOnce();
14301421
});

0 commit comments

Comments
 (0)