remaining PR feedback

Author: Jesse Haigh

Sources/SwiftDocC/Checker/Checkers/InvalidCodeBlockOption.swift

@@ -8,15 +8,15 @@
  See https://swift.org/CONTRIBUTORS.txt for Swift project authors
 */
 
-public import Foundation
-public import Markdown
+internal import Foundation
+internal import Markdown
 
 /**
  Code blocks can have a `nocopy` option after the \`\`\`, in the language line.
 `nocopy` can be immediately after the \`\`\` or after a specified language and a comma (`,`).
  */
-public struct InvalidCodeBlockOption: Checker {
-    public var problems = [Problem]()
+internal struct InvalidCodeBlockOption: Checker {
+    var problems = [Problem]()
 
     /// Parsing options for code blocks
     private let knownOptions = RenderBlockContent.CodeListing.knownOptions
@@ -26,11 +26,11 @@ public struct InvalidCodeBlockOption: Checker {
     /// Creates a new checker that detects documents with multiple titles.
     ///
     /// - Parameter sourceFile: The URL to the documentation file that the checker checks.
-    public init(sourceFile: URL?) {
+    init(sourceFile: URL?) {
         self.sourceFile = sourceFile
     }
 
-    public mutating func visitCodeBlock(_ codeBlock: CodeBlock) {
+    mutating func visitCodeBlock(_ codeBlock: CodeBlock) {
         let info = codeBlock.language?.trimmingCharacters(in: .whitespacesAndNewlines) ?? ""
         guard !info.isEmpty else { return }
 

Sources/SwiftDocC/Model/Rendering/Content/RenderBlockContent.swift

@@ -124,12 +124,12 @@ public enum RenderBlockContent: Equatable {
         public var code: [String]
         /// Additional metadata for this code block.
         public var metadata: RenderContentMetadata?
-        public var copyToClipboard: Bool = true
+        public var copyToClipboard: Bool
 
         public enum OptionName: String, CaseIterable {
             case nocopy
 
-            init?<S: StringProtocol>(caseInsensitive raw: S) {
+            init?(caseInsensitive raw: some StringProtocol) {
                 self.init(rawValue: raw.lowercased())
             }
         }
@@ -139,7 +139,7 @@ public enum RenderBlockContent: Equatable {
         }
 
         /// Make a new `CodeListing` with the given data.
-        public init(syntax: String?, code: [String], metadata: RenderContentMetadata?, copyToClipboard: Bool) {
+        public init(syntax: String?, code: [String], metadata: RenderContentMetadata?, copyToClipboard: Bool = true) {
             self.syntax = syntax
             self.code = code
             self.metadata = metadata

Sources/SwiftDocC/Model/Rendering/RenderContentCompiler.swift

@@ -70,21 +70,13 @@ struct RenderContentCompiler: MarkupVisitor {
 
             let options = parseLanguageString(codeBlock.language)
 
-            var listing = RenderBlockContent.CodeListing(
+            let listing = RenderBlockContent.CodeListing(
                 syntax: options.lang ?? bundle.info.defaultCodeListingLanguage,
                 code: codeBlock.code.splitByNewlines,
                 metadata: nil,
-                copyToClipboard: true // default value
+                copyToClipboard: options.tokens.contains(.nocopy)
             )
 
-            // apply code block options
-            for option in options.tokens {
-                switch option {
-                case .nocopy:
-                    listing.copyToClipboard = false
-                }
-            }
-
             return [RenderBlockContent.codeListing(listing)]
 
         } else {