OpenBSD support. #1348
Open
OpenBSD support. #1348
+28
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is potential for simplifying some of these conditional chains. For now, I have avoided doing this since this should be picked onto the release branch and simply extending the chains limits the risk scope slightly.
Member
Author
|
@swift-ci please test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add preliminary OpenBSD support.
There is potential for simplifying some of these conditional chains. For now, I have avoided doing this since this should be picked onto the release branch and simply extending the chains limits the risk scope slightly.
Dependencies
None.
Testing
CI testing should be sufficient to ensure the change does not affect other platforms.
Testing on OpenBSD requires the platform and the toolchain and the details of setting up an environment are out of scope.
I have run
swift buildlocally on OpenBSD and this succeeds after this change.swift teston Linux with this change passes normally.On OpenBSD, there seems to be some nontrivial problems related to LMDB on the platform:
LMDBTestsand a null-pointer dereference at the LMDB layer causes crashes duringExternalRenderNodeTests,IndexActionTests,NavigatorIndexTestsandConvertActionTests. Additionally, testsConvertSubcommandTests.testAdditionalSymbolGraphFilesandConvertSubcommandTests.testWithoutBundlefails. The failures and LMDB issues should probably be dealt with outside of this change.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded