Removes TODOs and FIXMEs that are no longer applicable

Author: ahoppen

Sources/SwiftParser/Availability.swift

@@ -145,8 +145,6 @@ extension Parser {
       case (.unavailable, let handle)?,
         (.noasync, let handle)?:
         let argument = self.eat(handle)
-        // FIXME: Can we model this in SwiftSyntax by making the
-        // 'labeled' argument part optional?
         entry = .token(argument)
       case (.star, _)?:
         entry = self.parseAvailabilitySpec()
@@ -177,8 +175,6 @@ extension Parser {
   /// Parse an availability argument.
   mutating func parseAvailabilitySpec() -> RawAvailabilityArgumentSyntax.Argument {
     if let star = self.consumeIfContextualPunctuator("*") {
-      // FIXME: Use makeAvailabilityVersionRestriction here - but swift-format
-      // doesn't expect it.
       return .token(star)
     }
 

Sources/SwiftParser/Declarations.swift

@@ -135,8 +135,6 @@ extension TokenConsumer {
       }
 
       // Otherwise, parse it as an expression.
-      // FIXME: C++ parser returns true if this is a top-level non-"script" files.
-      // But we don't have "is library" flag.
       return false
     case .some(_):
       // All other decl start keywords unconditionally start a decl.
@@ -1670,8 +1668,10 @@ extension Parser {
       let (unexpectedBeforeIdentifier, identifier) = self.expectIdentifier(allowSelfOrCapitalSelfAsIdentifier: true)
       var types = [RawDesignatedTypeSyntax]()
       while let comma = self.consume(if: .comma) {
-        // FIXME: The compiler accepts... anything here. This is a bug.
-        // let (unexpectedBeforeDesignatedType, designatedType) = self.expectIdentifier()
+        // Technically, we should only accept identifiers for the designated
+        // types but the C++ parser accepted anything, which we mimick.
+        // It's not worth fixing since designated types are no longer allowed
+        // anyway.
         let designatedType = self.consumeAnyToken()
         types.append(
           RawDesignatedTypeSyntax(

Sources/SwiftParser/Expressions.swift

@@ -791,7 +791,6 @@ extension Parser {
 
       // Check for a trailing closure, if allowed.
       if self.at(.leftBrace) && !leadingExpr.raw.kind.isLiteral && self.withLookahead({ $0.atValidTrailingClosure(flavor: flavor) }) {
-        // FIXME: if Result has a trailing closure, break out.
         // Add dummy blank argument list to the call expression syntax.
         let list = RawLabeledExprListSyntax(elements: [], arena: self.arena)
         let (first, rest) = self.parseTrailingClosures(flavor: flavor)
@@ -1472,7 +1471,6 @@ extension Parser {
     }
 
     if let (colon, rsquare) = self.consume(if: .colon, followedBy: .rightSquare) {
-      // FIXME: We probably want a separate node for the empty case.
       return RawExprSyntax(
         RawDictionaryExprSyntax(
           unexpectedBeforeLSquare,

Sources/SwiftParser/TopLevel.swift

@@ -150,8 +150,6 @@ extension Parser {
       )
     }
 
-    // FIXME: It is unfortunate that the Swift book refers to these as
-    // "statements" and not "items".
     let item = self.parseItem(isAtTopLevel: isAtTopLevel, allowInitDecl: allowInitDecl)
     let semi = self.consume(if: .semicolon)
     var trailingSemis: [RawTokenSyntax] = []

Sources/SwiftParser/Types.swift

@@ -380,7 +380,6 @@ extension Parser {
   /// Parse a type placeholder.
   mutating func parsePlaceholderType() -> RawIdentifierTypeSyntax {
     let (unexpectedBeforeName, name) = self.expect(.wildcard)
-    // FIXME: Need a better syntax node than this
     return RawIdentifierTypeSyntax(
       unexpectedBeforeName,
       name: name,

Sources/SwiftParserDiagnostics/MissingTokenError.swift

@@ -49,8 +49,6 @@ extension ParseDiagnosticsGenerator {
   private func handleInvalidIdentifier(invalidToken: TokenSyntax, missingToken: TokenSyntax, invalidTokenContainer: UnexpectedNodesSyntax) -> Bool {
     let fixIts: [FixIt]
     if invalidToken.tokenKind.isLexerClassifiedKeyword || invalidToken.tokenKind.isDollarIdentifier {
-      // TODO: Should the parser add the text with backticks to the missing
-      // node? Then this could just make missing/present.
       fixIts = [
         FixIt(
           message: .wrapInBackticks,

Sources/SwiftParserDiagnostics/MultiLineStringLiteralDiagnosticsGenerator.swift

@@ -133,7 +133,6 @@ final class MultiLineStringLiteralIndentationDiagnosticsGenerator: SyntaxVisitor
     case .stringSegment(let stringSegment):
       return stringSegment.last?.isNewline ?? false
     default:
-      // FIXME: newlines should never be part of trailing trivia
       return previousToken.trailingTrivia.contains(where: { $0.isNewline })
     }
   }

Sources/SwiftSyntax/Raw/RawSyntaxNodeProtocol.swift

@@ -270,9 +270,6 @@ public struct RawTokenSyntax: RawSyntaxNodeProtocol {
     trailingTriviaPieces: [RawTriviaPiece] = [],
     arena: __shared SyntaxArena
   ) {
-    // FIXME: Allow creating a `RawSyntax.parsedToken()` with a string literal
-    // for text. Currently it asserts that the string buffer is not contained
-    // within the `arena`.
     self.init(
       materialized: kind,
       text: text ?? kind.defaultText ?? "",

Sources/SwiftSyntax/SyntaxChildren.swift

@@ -153,9 +153,9 @@ struct RawSyntaxChildren: BidirectionalCollection {
 
   /// The rootId of the tree the child nodes belong to
   private let rootId: UInt
+
   /// The number of children in `parent`. Cached to avoid reaching into `parent` for every index
   /// advancement
-  // FIXME: Do we need this cached?
   private let numberOfChildren: Int
 
   let startIndex: SyntaxChildrenIndex

Sources/SwiftSyntaxBuilder/Syntax+StringInterpolation.swift

@@ -268,7 +268,6 @@ extension String: ExpressibleByLiteralSyntax {
 
 extension ExpressibleByLiteralSyntax where Self: BinaryInteger {
   public func makeLiteralSyntax() -> IntegerLiteralExprSyntax {
-    // TODO: Radix selection? Thousands separators?
     let digits = String(self, radix: 10)
     return IntegerLiteralExprSyntax(literal: .integerLiteral(digits))
   }
@@ -305,7 +304,6 @@ extension ExpressibleByLiteralSyntax where Self: FloatingPoint, Self: LosslessSt
       )
 
     case .negativeNormal, .negativeSubnormal, .positiveZero, .positiveSubnormal, .positiveNormal:
-      // TODO: Thousands separators?
       let digits = String(self)
       return ExprSyntax(FloatLiteralExprSyntax(literal: .floatLiteral(digits)))
     }