Use PrintOptions::forDebugging in a few more places

Use for a few `dump` methods, generic signature debugging, and enable
by default for swift-ide-test.

Author: hamishknight

lib/AST/ASTDumper.cpp

@@ -6820,7 +6820,7 @@ void RequirementRepr::dump() const {
 }
 
 void GenericParamList::dump() const {
-  print(llvm::errs());
+  print(llvm::errs(), PrintOptions::forDebugging());
   llvm::errs() << '\n';
 }
 
@@ -6829,11 +6829,11 @@ void LayoutConstraint::dump() const {
     llvm::errs() << "(null)\n";
     return;
   }
-  getPointer()->print(llvm::errs());
+  getPointer()->print(llvm::errs(), PrintOptions::forDebugging());
 }
 
 void GenericSignature::dump() const {
-  print(llvm::errs());
+  print(llvm::errs(), PrintOptions::forDebugging());
   llvm::errs() << '\n';
 }
 
@@ -6868,7 +6868,7 @@ void InheritedEntry::dump(llvm::raw_ostream &os) const {
     os << '@' << getDumpString(getExplicitSafety()) << ' ';
   if (isSuppressed())
     os << "~";
-  getType().print(os);
+  getType().print(os, PrintOptions::forDebugging());
 }
 
 void InheritedEntry::dump() const { dump(llvm::errs()); }

lib/Sema/TypeCheckDeclPrimary.cpp

@@ -2055,7 +2055,7 @@ static void dumpGenericSignature(ASTContext &ctx, GenericContext *GC) {
         GC->printContext(llvm::errs());
       }
       llvm::errs() << "Generic signature: ";
-      PrintOptions Opts;
+      PrintOptions Opts = PrintOptions::forDebugging();
       Opts.ProtocolQualifiedDependentMemberTypes = true;
       Opts.PrintInverseRequirements =
           !ctx.TypeCheckerOpts.DebugInverseRequirements;
@@ -3427,7 +3427,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
       PD->dumpRef(llvm::errs());
       llvm::errs() << "\n";
       llvm::errs() << "Requirement signature: ";
-      PrintOptions Opts;
+      PrintOptions Opts = PrintOptions::forDebugging();
       Opts.ProtocolQualifiedDependentMemberTypes = true;
       Opts.PrintInverseRequirements =
           !Ctx.TypeCheckerOpts.DebugInverseRequirements;

test/Generics/parameter-pack-requirements.swift

@@ -117,7 +117,7 @@ protocol PP {
 struct G<each T> {}
 
 // CHECK-LABEL: sameTypeMatch1
-// CHECK-NEXT: <T, each U, each V where T : PP, repeat each U : PP, repeat each V : PP, T.[PP]A == G<repeat (each U).[PP]A>, repeat (each U).[PP]A == (each V).[PP]A>
+// CHECK-NEXT: <T, each U, each V where T : PP, repeat each U : PP, repeat each V : PP, T.[PP]A == G<Pack{repeat (each U).[PP]A}>, repeat (each U).[PP]A == (each V).[PP]A>
 func sameTypeMatch1<T: PP, each U: PP, each V: PP>(t: T, u: repeat each U, v: repeat each V)
   where T.A == G<repeat (each U).A>, T.A == G<repeat (each V).A>,
         (repeat (each U, each V)) : Any {}

tools/swift-ide-test/swift-ide-test.cpp

@@ -585,6 +585,11 @@ PreferTypeRepr("prefer-type-repr",
                llvm::cl::cat(Category),
                llvm::cl::init(true));
 
+static llvm::cl::opt<bool> PrintForDebugging(
+    "debug-print",
+    llvm::cl::desc("Print using the debug representation for types"),
+    llvm::cl::cat(Category), llvm::cl::init(true));
+
 static llvm::cl::opt<bool>
 FullyQualifiedTypes("fully-qualified-types",
                     llvm::cl::desc("Print fully qualified types"),
@@ -4735,6 +4740,7 @@ int main(int argc, char *argv[]) {
       return PrintOptions::printDocInterface();
     } else {
       auto PrintOpts = PrintOptions::printEverything();
+      PrintOpts.PrintTypesForDebugging = options::PrintForDebugging;
       PrintOpts.FullyQualifiedTypes = options::FullyQualifiedTypes;
       PrintOpts.FullyQualifiedTypesIfAmbiguous =
         options::FullyQualifiedTypesIfAmbiguous;