We need at least 7 samples for scale-test to produce a reliable result

slavapestov · slavapestov · commit 0aece0c28e84 · 2025-10-15T16:13:25.000-04:00
One test was miscategorized as 'fast' because of this issue, but it
would occasionally fail. It turns out it always fails once you ask
for 7 points or more, so let's fix that and move it back to 'slow'.

Fixes rdar://162597936.
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-43943.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-43943.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 6 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 extension String {
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-46253-2.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-46253-2.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/46253
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-46253.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-46253.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/46253
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-47685.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-47685.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/47685
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-47896.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-47896.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 6 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/47896
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-48418.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-48418.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 6 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 enum A {
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-48588.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-48588.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/48588
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-49650.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-49650.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/49650
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-50046.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-50046.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/50046
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-52563.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-52563.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/52563
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-53001.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-53001.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/53001
diff --git a/validation-test/Sema/type_checker_perf/fast/issue-54695.swift.gyb b/validation-test/Sema/type_checker_perf/fast/issue-54695.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/54695
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar118993030-literal.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar118993030-literal.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumConstraintScopes %s
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumConstraintScopes %s
 // REQUIRES: asserts,no_asan
 
 struct Root {
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar18724501.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar18724501.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 typealias X = (Range<Int>, [Range<Int>])
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar20233198_any.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar20233198_any.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 2 --end 6 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 2 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 let _ = (UInt8(0)
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar20233198_explicit_overloads.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar20233198_explicit_overloads.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 2 --end 6 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 2 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 func overload(_ x: Int) -> Int { return x }
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar20233198_named.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar20233198_named.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 2 --end 6 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 2 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 let tuple = (UInt8(0)
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar20233198_typed.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar20233198_typed.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 2 --end 6 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 2 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 let tuple: (UInt8
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar20233198_weak.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar20233198_weak.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 2 --end 6 --step 1 --select NumLeafScopes %s -Xfrontend=-verify
+// RUN: %scale-test --begin 2 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-verify
 // REQUIRES: asserts,no_asan
 
 weak var tuple = (UInt8(0)   // expected-error {{'weak' may only be applied to}}
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar21070413.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar21070413.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 enum E: UInt {
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar21328584.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar21328584.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 struct S {
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar21930551.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar21930551.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 2 --end 6 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 2 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 let _ = [
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar22810685.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar22810685.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 let _: [String : (Int, Int) -> Bool] = [
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar25866240.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar25866240.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: not %scale-test --begin 1 --end 5 --step 1 --select incrementScopeCounter %s
+// RUN: not %scale-test --begin 1 --end 7 --step 1 --select incrementScopeCounter %s
 // REQUIRES: OS=macosx
 // REQUIRES: asserts
 
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar30596744_2.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar30596744_2.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s --expected-exit-code 1
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s --expected-exit-code 1
 // REQUIRES: asserts,no_asan
 
 % enum_cases = 3
diff --git a/validation-test/Sema/type_checker_perf/fast/rdar31563957.swift.gyb b/validation-test/Sema/type_checker_perf/fast/rdar31563957.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 
 struct rdar33511986 {
diff --git a/validation-test/Sema/type_checker_perf/fast/simd_scalar_multiple.swift.gyb b/validation-test/Sema/type_checker_perf/fast/simd_scalar_multiple.swift.gyb
diff --git a/validation-test/Sema/type_checker_perf/slow/collections_chained_with_plus.swift.gyb b/validation-test/Sema/type_checker_perf/slow/collections_chained_with_plus.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --invert-result --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --invert-result --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 struct Value: RandomAccessCollection, RangeReplaceableCollection {
diff --git a/validation-test/Sema/type_checker_perf/slow/issue-44074.swift.gyb b/validation-test/Sema/type_checker_perf/slow/issue-44074.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --invert-result --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --invert-result --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 func slow() {
diff --git a/validation-test/Sema/type_checker_perf/slow/issue-54830.swift.gyb b/validation-test/Sema/type_checker_perf/slow/issue-54830.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --invert-result --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --invert-result --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/54830
diff --git a/validation-test/Sema/type_checker_perf/slow/issue-55762.swift.gyb b/validation-test/Sema/type_checker_perf/slow/issue-55762.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --invert-result --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --invert-result --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/55762
diff --git a/validation-test/Sema/type_checker_perf/slow/issue-58051.swift.gyb b/validation-test/Sema/type_checker_perf/slow/issue-58051.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --invert-result --begin 1 --end 6 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
+// RUN: %scale-test --invert-result --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck
 // REQUIRES: asserts, no_asan
 
 // https://github.com/swiftlang/swift/issues/58051
diff --git a/validation-test/Sema/type_checker_perf/slow/rdar30596744_1.swift.gyb b/validation-test/Sema/type_checker_perf/slow/rdar30596744_1.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --invert-result --begin 1 --end 5 --step 1 --select NumLeafScopes %s --expected-exit-code 1
+// RUN: %scale-test --invert-result --begin 1 --end 7 --step 1 --select NumLeafScopes %s --expected-exit-code 1
 // REQUIRES: asserts,no_asan
 
 % enum_cases = N
diff --git a/validation-test/Sema/type_checker_perf/slow/rdar33289839.swift.gyb b/validation-test/Sema/type_checker_perf/slow/rdar33289839.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --invert-result --begin 2 --end 6 --step 1 --select NumLeafScopes %s
+// RUN: %scale-test --invert-result --begin 2 --end 7 --step 1 --select NumLeafScopes %s
 // REQUIRES: asserts,no_asan
 // REQUIRES: rdar42969824,no_asan
 
diff --git a/validation-test/Sema/type_checker_perf/slow/simd_scalar_multiple.swift.gyb b/validation-test/Sema/type_checker_perf/slow/simd_scalar_multiple.swift.gyb
@@ -0,0 +1,9 @@
+// RUN: %scale-test --invert --begin 1 --end 7 --step 1 --select NumLeafScopes %s
+// REQUIRES: asserts,no_asan
+
+func f(c: Float, a: SIMD2<Float>) -> SIMD2<Float> {
+  return (c * a)
+%for i in range(1, N):
+         + (c * a)
+%end
+}
diff --git a/validation-test/compiler_scale/var_decl_usage_checker.swift.gyb b/validation-test/compiler_scale/var_decl_usage_checker.swift.gyb
@@ -1,4 +1,4 @@
-// RUN: %scale-test --begin 1 --end 5 --step 1 --select VarDeclUsageCheckerExprVisits %s
+// RUN: %scale-test --begin 1 --end 7 --step 1 --select VarDeclUsageCheckerExprVisits %s
 // REQUIRES: asserts
 
 protocol Proto {}

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// RUN: %scale-test --begin 1 --end 6 --step 1 --select NumLeafScopes %s`
	`1`	`+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s`
`2`	`2`	`// REQUIRES: asserts,no_asan`
`3`	`3`
`4`	`4`	`extension String {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// RUN: %scale-test --begin 1 --end 5 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck`
	`1`	`+// RUN: %scale-test --begin 1 --end 7 --step 1 --select NumLeafScopes %s -Xfrontend=-typecheck`
`2`	`2`	`// REQUIRES: asserts, no_asan`
`3`	`3`
`4`	`4`	`// https://github.com/swiftlang/swift/issues/46253`