Bailout on address apply result while computng argument escaping effects

Author: meg-gupta

SwiftCompilerSources/Sources/Optimizer/Utilities/EscapeUtils.swift

@@ -725,7 +725,7 @@ fileprivate struct EscapeWalker<V: EscapeVisitor> : ValueDefUseWalker,
         }
       case .escapingToReturn(let toPath, let exclusive):
         if effect.matches(calleeArgIdx, argPath.projectionPath) {
-          guard let fas = apply as? FullApplySite, let result = fas.singleDirectResult else {
+          guard let fas = apply as? FullApplySite, let result = fas.singleDirectResult, result.type.isObject else {
             return isEscaping
           }
 

test/SILOptimizer/escape_effects.sil

@@ -414,3 +414,42 @@ bb0(%0 : $*Wrapper):
   %2 = struct_element_addr %0, #Wrapper._k
   return %2
 }
+
+// CHECK: sil [ossa] @call_mutate_accessor : $@convention(thin) (@inout Wrapper, @owned Klass) -> () {
+// CHECK-NOT: [.*]
+// CHECK: bb0({{.*}}):
+sil [ossa] @call_mutate_accessor : $@convention(thin) (@inout Wrapper, @owned Klass) -> () {
+bb0(%0 : $*Wrapper, %1 : @owned $Klass):
+  %func = function_ref @mutate_accessor : $@convention(thin) (@inout Wrapper) -> @inout Klass
+  %addr = apply %func(%0) : $@convention(thin) (@inout Wrapper) -> @inout Klass
+  store %1 to [assign] %addr
+  %r = tuple ()
+  return %r
+}
+
+sil [ossa] @modify_accessor : $@yield_once @convention(thin) (@inout Wrapper) -> @yields @inout Klass {
+bb0(%0 : $*Wrapper):
+  %2 = struct_element_addr %0, #Wrapper._k
+  yield %2, resume bb1, unwind bb2
+
+bb1:
+  %t = tuple ()
+  return %t
+
+bb2:
+  unwind
+}
+
+// CHECK: sil [ossa] @call_modify_accessor : $@convention(thin) (@inout Wrapper, @owned Klass) -> () {
+// CHECK-NOT: [.*]
+// CHECK: bb0({{.*}}):
+sil [ossa] @call_modify_accessor : $@convention(thin) (@inout Wrapper, @owned Klass) -> () {
+bb0(%0 : $*Wrapper, %1 : @owned $Klass):
+  %func = function_ref @modify_accessor : $@yield_once @convention(thin) (@inout Wrapper) -> @yields @inout Klass
+  (%addr, %tok) = begin_apply %func(%0) : $@yield_once @convention(thin) (@inout Wrapper) -> @yields @inout Klass
+  store %1 to [assign] %addr
+  end_apply %tok as $()
+  %r = tuple ()
+  return %r
+}
+