cleanup and remove the new tests that fail at the moment

Author: jamieQ

lib/SILGen/SILGenDecl.cpp

@@ -1011,10 +1011,10 @@ class LetValueInitialization : public Initialization {
            "called LetValueInit::finishInitialization twice!");
 
     if (!address) {
-      // We should have already in the non-address case.
+      // We should have already registered in the non-address case.
       assert(SGF.VarLocs.count(vd) && "Didn't bind a value to this let!");
     } else {
-      // We delayed the emission to catch forward declaration uses.
+      // We should have delayed the emission to catch forward declaration uses.
       assert(SGF.VarLocs.count(vd) == 0 && "Should not have emitted the address-only let!");
       SGF.VarLocs[vd] = SILGenFunction::VarLoc(address,
                                                SILAccessEnforcement::Unknown);

test/SILOptimizer/definite_init_address_only_let.swift

@@ -39,34 +39,3 @@ func quz<T>(a: Bool, t: T) {
     return
   }
 }
-
-// https://github.com/swiftlang/swift/issues/84909
-
-func uninit_closure_reference() {
-  func passthrough(_ a: () -> Any) -> Any { a() }
-
-  let initMe = passthrough { initMe }
-  // expected-error @-1 {{constant 'initMe' used before being initialized}}
-  // expected-note @-2 {{defined here}}
-
-  let inline = { () -> Any in inline }()
-  // expected-error @-1 {{constant 'inline' used before being initialized}}
-  // expected-note @-2 {{defined here}}
-
-  // these should not regress
-  func castAny(_ a: Any) {
-    let directUncond = a as! Int
-    _ = directUncond
-
-    let directCond = a as? Int
-    _ = directCond
-
-    let twoPhaseUncond: Int
-    twoPhaseUncond = a as! Int
-    _ = twoPhaseUncond
-
-    let twoPhasCond: Int?
-    twoPhasCond = a as? Int
-    _ = twoPhasCond
-  }
-}