[Swiftify] make protocol extension methods public

Author: hnrklssn

lib/Macros/Sources/SwiftMacros/SwiftifyImportMacro.swift

@@ -1808,11 +1808,21 @@ public struct SwiftifyImportProtocolMacro: ExtensionMacro {
       }
       let overloads = try arguments.map {
         let (method, args) = try parseProtocolMacroParam($0, methods: methods)
-        let function = try constructOverloadFunction(
+        let hasVisibilityModifier = method.modifiers.contains { modifier in
+          let modName = modifier.name.trimmed.text
+          return modName == "public" || modName == "internal" || modName == "open"
+            || modName == "private" || modName == "filePrivate"
+        }
+        let result = try constructOverloadFunction(
           forDecl: method, leadingTrivia: Trivia(), args: args,
           spanAvailability: spanAvailability,
           typeMappings: typeMappings)
-        return MemberBlockItemSyntax(decl: function)
+        guard let newMethod = result.as(FunctionDeclSyntax.self)?
+          .with(\.modifiers, method.modifiers
+              + (hasVisibilityModifier ? [] : [DeclModifierSyntax(name: .identifier("public"))])) else {
+          throw RuntimeError("expected FunctionDeclSyntax but got \(result.kind) for \(method.description)")
+        }
+        return MemberBlockItemSyntax(decl: newMethod)
       }
 
       return [ExtensionDeclSyntax(extensionKeyword: .identifier("extension"), extendedType: type,

test/Macros/SwiftifyImport/CountedBy/Protocol.swift

@@ -42,7 +42,7 @@ protocol OverloadedProtocol {
 ------------------------------
 extension SimpleProtocol {
     /// This is an auto-generated wrapper for safer interop
-@_alwaysEmitIntoClient @_disfavoredOverload
+@_alwaysEmitIntoClient @_disfavoredOverload public
       func myFunc(_ ptr: UnsafeBufferPointer<CInt>) {
         let len = CInt(exactly: ptr.count)!
         return unsafe myFunc(ptr.baseAddress!, len)
@@ -53,15 +53,15 @@ extension SimpleProtocol {
 ------------------------------
 extension SpanProtocol {
     /// This is an auto-generated wrapper for safer interop
-@_alwaysEmitIntoClient @_disfavoredOverload
+@_alwaysEmitIntoClient @_disfavoredOverload public
       func foo(_ ptr: Span<CInt>) {
         let len = CInt(exactly: ptr.count)!
         return unsafe ptr.withUnsafeBufferPointer { _ptrPtr in
           return unsafe foo(_ptrPtr.baseAddress!, len)
         }
     }
     /// This is an auto-generated wrapper for safer interop
-@_alwaysEmitIntoClient @_lifetime(borrow self) @_disfavoredOverload
+@_alwaysEmitIntoClient @_lifetime(borrow self) @_disfavoredOverload public
       func bar(_ len: CInt) -> Span<CInt> {
         return unsafe _swiftifyOverrideLifetime(Span<CInt>(_unsafeStart: unsafe bar(len), count: Int(len)), copying: ())
     }
@@ -71,7 +71,7 @@ extension SpanProtocol {
 ------------------------------
 extension MixedProtocol {
     /// This is an auto-generated wrapper for safer interop
-@_alwaysEmitIntoClient @_disfavoredOverload
+@_alwaysEmitIntoClient @_disfavoredOverload public
       /// Some doc comment
       func foo(_ ptr: Span<CInt>) {
         let len = CInt(exactly: ptr.count)!
@@ -80,7 +80,7 @@ extension MixedProtocol {
         }
     }
     /// This is an auto-generated wrapper for safer interop
-@_alwaysEmitIntoClient @_disfavoredOverload
+@_alwaysEmitIntoClient @_disfavoredOverload public
       func bar(_ ptr: UnsafeBufferPointer<CInt>) {
         let len = CInt(exactly: ptr.count)!
         return unsafe bar(ptr.baseAddress!, len)
@@ -91,13 +91,13 @@ extension MixedProtocol {
 ------------------------------
 extension OverloadedProtocol {
     /// This is an auto-generated wrapper for safer interop
-@_alwaysEmitIntoClient @_disfavoredOverload
+@_alwaysEmitIntoClient @_disfavoredOverload public
       func foo(_ ptr: UnsafeBufferPointer<CInt>) {
         let len1 = CInt(exactly: ptr.count)!
         return unsafe foo(ptr.baseAddress!, len1)
     }
     /// This is an auto-generated wrapper for safer interop
-@_alwaysEmitIntoClient @_disfavoredOverload
+@_alwaysEmitIntoClient @_disfavoredOverload public
       func foo(bar: UnsafeBufferPointer<CInt>) {
         let len2 = CInt(exactly: bar.count)!
         return unsafe foo(bar: bar.baseAddress!, len2)