Merge pull request #86064 from cachemeifyoucan/eng/PR-166557713

cachemeifyoucan · web-flow · commit ce2cff574aaa · 2025-12-15T17:17:13.000-08:00
[ModuleLoader] Remove `llvm_unreachable` in findModuleFilesInDirectory()
diff --git a/lib/Frontend/ModuleInterfaceLoader.cpp b/lib/Frontend/ModuleInterfaceLoader.cpp
@@ -2364,7 +2364,6 @@ std::error_code ExplicitSwiftModuleLoader::findModuleFilesInDirectory(
     std::unique_ptr<llvm::MemoryBuffer> *ModuleSourceInfoBuffer,
     bool IsCanImportLookup, bool IsFramework,
     bool IsTestableDependencyLookup) {
-  llvm_unreachable("Not supported in the Explicit Swift Module Loader.");
   return std::make_error_code(std::errc::not_supported);
 }
 
@@ -2712,7 +2711,6 @@ std::error_code ExplicitCASModuleLoader::findModuleFilesInDirectory(
     std::unique_ptr<llvm::MemoryBuffer> *ModuleSourceInfoBuffer,
     bool IsCanImportLookup, bool IsFramework,
     bool IsTestableDependencyLookup) {
-  llvm_unreachable("Not supported in the Explicit Swift Module Loader.");
   return std::make_error_code(std::errc::not_supported);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2364,7 +2364,6 @@ std::error_code ExplicitSwiftModuleLoader::findModuleFilesInDirectory(`
`2364`	`2364`	`std::unique_ptr<llvm::MemoryBuffer> *ModuleSourceInfoBuffer,`
`2365`	`2365`	`bool IsCanImportLookup, bool IsFramework,`
`2366`	`2366`	`bool IsTestableDependencyLookup) {`
`2367`		`- llvm_unreachable("Not supported in the Explicit Swift Module Loader.");`
`2368`	`2367`	`return std::make_error_code(std::errc::not_supported);`
`2369`	`2368`	`}`
`2370`	`2369`
`@@ -2712,7 +2711,6 @@ std::error_code ExplicitCASModuleLoader::findModuleFilesInDirectory(`
`2712`	`2711`	`std::unique_ptr<llvm::MemoryBuffer> *ModuleSourceInfoBuffer,`
`2713`	`2712`	`bool IsCanImportLookup, bool IsFramework,`
`2714`	`2713`	`bool IsTestableDependencyLookup) {`
`2715`		`- llvm_unreachable("Not supported in the Explicit Swift Module Loader.");`
`2716`	`2714`	`return std::make_error_code(std::errc::not_supported);`
`2717`	`2715`	`}`
`2718`	`2716`