Migrate to v8 of @typescript-eslint (#1178)

* Migrate to v8 of @typescript-eslint

In order to get dependabot back on (#1177) and get on latest typescript,
we need to fix new rules first
* Turn off some new defaults
* Fix some source for new defaults

Issue: #1169

* Fix prettier style

Author: award999

.eslintrc.json

@@ -10,9 +10,19 @@
     "curly": "error",
     "eqeqeq": "warn",
     "no-throw-literal": "warn",
-    "semi": "off",
+    // TODO "@typescript-eslint/semi" rule moved to https://eslint.style
+    "semi": "error",
+    // Mostly fails tests, ex. expect(...).to.be.true returns a Chai.Assertion
+    "@typescript-eslint/no-unused-expressions": "off",
     "@typescript-eslint/no-non-null-assertion": "off",
-    "@typescript-eslint/semi": "error"
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      {
+        "args": "all",
+        "argsIgnorePattern": "^_",
+        "caughtErrors": "none"
+      }
+    ]
   },
   "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended", "prettier"],
   "ignorePatterns": ["out", "dist", "**/*.d.ts"]

.github/dependabot.yml

@@ -14,8 +14,6 @@ updates:
         update-types: ["version-update:semver-major"]
       - dependency-name: "strip-ansi"
         update-types: ["version-update:semver-major"]
-      - dependency-name: "@typescript-eslint/*"
-        update-types: ["version-update:semver-major"]
       - dependency-name: "*chai*"
         update-types: ["version-update:semver-major"]
       - dependency-name: "@vscode/vsce"