Merge pull request swiftlang#32295 from eeckstein/fix-silgen-crash

Don't require the stdlib to contain the _finalizeUninitializedArray intrinsic function.

Author: eeckstein

lib/SILGen/SILGenApply.cpp

@@ -4963,17 +4963,26 @@ void SILGenFunction::emitUninitializedArrayDeallocation(SILLocation loc,
 }
 
 ManagedValue SILGenFunction::emitUninitializedArrayFinalization(SILLocation loc,
-                                                      SILValue array) {
+                                                      ManagedValue array) {
   auto &Ctx = getASTContext();
-  auto finalize = Ctx.getFinalizeUninitializedArray();
+  FuncDecl *finalize = Ctx.getFinalizeUninitializedArray();
+  
+  // The _finalizeUninitializedArray function only needs to be called if the
+  // library contains it.
+  // The Array implementation in the stdlib <= 5.3 does not use SIL COW
+  // support yet and therefore does not provide the _finalizeUninitializedArray
+  // intrinsic function.
+  if (!finalize)
+    return array;
 
-  CanType arrayTy = array->getType().getASTType();
+  SILValue arrayVal = array.forward(*this);
+  CanType arrayTy = arrayVal->getType().getASTType();
 
   // Invoke the intrinsic.
   auto subMap = arrayTy->getContextSubstitutionMap(SGM.M.getSwiftModule(),
                                                    Ctx.getArrayDecl());
   RValue result = emitApplyOfLibraryIntrinsic(loc, finalize, subMap,
-                              ManagedValue::forUnmanaged(array),
+                              ManagedValue::forUnmanaged(arrayVal),
                               SGFContext());
   return std::move(result).getScalarValue();
 }

lib/SILGen/SILGenExpr.cpp

@@ -2117,7 +2117,7 @@ ManagedValue Lowering::emitEndVarargs(SILGenFunction &SGF, SILLocation loc,
   if (array.hasCleanup())
     SGF.Cleanups.setCleanupState(array.getCleanup(), CleanupState::Active);
 
-  return SGF.emitUninitializedArrayFinalization(loc, array.forward(SGF));
+  return SGF.emitUninitializedArrayFinalization(loc, std::move(array));
 }
 
 RValue RValueEmitter::visitTupleExpr(TupleExpr *E, SGFContext C) {

lib/SILGen/SILGenFunction.h

@@ -1187,7 +1187,8 @@ class LLVM_LIBRARY_VISIBILITY SILGenFunction
 
   CleanupHandle enterDeallocateUninitializedArrayCleanup(SILValue array);
   void emitUninitializedArrayDeallocation(SILLocation loc, SILValue array);
-  ManagedValue emitUninitializedArrayFinalization(SILLocation loc, SILValue array);
+  ManagedValue emitUninitializedArrayFinalization(SILLocation loc,
+                                                  ManagedValue array);
 
   /// Emit a cleanup for an owned value that should be written back at end of
   /// scope if the value is not forwarded.

lib/SILOptimizer/Mandatory/OSLogOptimization.cpp

@@ -539,14 +539,15 @@ static SILValue emitCodeForConstantArray(ArrayRef<SILValue> elements,
       module.findFunction(allocatorMangledName, SILLinkage::PublicExternal);
   assert(arrayAllocateFun);
 
-  FuncDecl *arrayFinalizeDecl = astContext.getFinalizeUninitializedArray();
-  assert(arrayFinalizeDecl);
-  std::string finalizeMangledName =
-      SILDeclRef(arrayFinalizeDecl, SILDeclRef::Kind::Func).mangle();
-  SILFunction *arrayFinalizeFun =
-      module.findFunction(finalizeMangledName, SILLinkage::SharedExternal);
-  assert(arrayFinalizeFun);
-  module.linkFunction(arrayFinalizeFun);
+  SILFunction *arrayFinalizeFun = nullptr;
+  if (FuncDecl *arrayFinalizeDecl = astContext.getFinalizeUninitializedArray()) {
+    std::string finalizeMangledName =
+        SILDeclRef(arrayFinalizeDecl, SILDeclRef::Kind::Func).mangle();
+    arrayFinalizeFun =
+        module.findFunction(finalizeMangledName, SILLinkage::SharedExternal);
+    assert(arrayFinalizeFun);
+    module.linkFunction(arrayFinalizeFun);
+  }
 
   // Call the _allocateUninitializedArray function with numElementsSIL. The
   // call returns a two-element tuple, where the first element is the newly
@@ -605,12 +606,13 @@ static SILValue emitCodeForConstantArray(ArrayRef<SILValue> elements,
                                   StoreOwnershipQualifier::Init);
     ++elementIndex;
   }
-  FunctionRefInst *arrayFinalizeRef =
-      builder.createFunctionRef(loc, arrayFinalizeFun);
-  ApplyInst *finalizedArray = builder.createApply(
-      loc, arrayFinalizeRef, subMap, ArrayRef<SILValue>(arraySIL));
-
-  return finalizedArray;
+  if (arrayFinalizeFun) {
+    FunctionRefInst *arrayFinalizeRef =
+        builder.createFunctionRef(loc, arrayFinalizeFun);
+    arraySIL = builder.createApply(loc, arrayFinalizeRef, subMap,
+                                   ArrayRef<SILValue>(arraySIL));
+  }
+  return arraySIL;
 }
 
 /// Given a SILValue \p value, return the instruction immediately following the