Merge branch '4.4' into 5.2

nicolas-grekas · nicolas-grekas · commit 0ff2b2332292 · 2021-07-05T15:28:55.000+02:00
* 4.4:
  cs fix
  [DependencyInjection][Console] tighten types
  [Lock] fix derivating semaphore from key
diff --git a/Store/SemaphoreStore.php b/Store/SemaphoreStore.php
@@ -62,7 +62,7 @@ private function lock(Key $key, bool $blocking)
             return;
         }
 
-        $keyId = crc32($key);
+        $keyId = unpack('i', md5($key, true))[1];
         $resource = sem_get($keyId);
         $acquired = @sem_acquire($resource, !$blocking);
 

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ private function lock(Key $key, bool $blocking)`
`62`	`62`	`return;`
`63`	`63`	`}`
`64`	`64`
`65`		`- $keyId = crc32($key);`
	`65`	`+ $keyId = unpack('i', md5($key, true))[1];`
`66`	`66`	`$resource = sem_get($keyId);`
`67`	`67`	`$acquired = @sem_acquire($resource, !$blocking);`
`68`	`68`