Skip to content

Commit 20e2169

Browse files
Merge branch '5.4' into 6.2
* 5.4: [DependencyInjection] Skip errored definitions deep-referenced as runtime exceptions [Messenger] Preserve existing Doctrine schema [HttpClient] Explicitly exclude CURLOPT_POSTREDIR
2 parents 1d86964 + ed4055b commit 20e2169

File tree

4 files changed

+5
-9
lines changed

4 files changed

+5
-9
lines changed

Store/DoctrineDbalPostgreSqlStore.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
use Doctrine\DBAL\Platforms\PostgreSQLPlatform;
1818
use Doctrine\DBAL\Schema\DefaultSchemaManagerFactory;
1919
use Doctrine\DBAL\Tools\DsnParser;
20-
use Doctrine\ORM\ORMSetup;
2120
use Symfony\Component\Lock\BlockingSharedLockStoreInterface;
2221
use Symfony\Component\Lock\BlockingStoreInterface;
2322
use Symfony\Component\Lock\Exception\InvalidArgumentException;
@@ -69,7 +68,7 @@ public function __construct(Connection|string $connOrUrl)
6968
$params = ['url' => $this->filterDsn($connOrUrl)];
7069
}
7170

72-
$config = class_exists(ORMSetup::class) ? ORMSetup::createConfiguration() : new Configuration();
71+
$config = new Configuration();
7372
if (class_exists(DefaultSchemaManagerFactory::class)) {
7473
$config->setSchemaManagerFactory(new DefaultSchemaManagerFactory());
7574
}

Store/DoctrineDbalStore.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
use Doctrine\DBAL\Schema\DefaultSchemaManagerFactory;
2121
use Doctrine\DBAL\Schema\Schema;
2222
use Doctrine\DBAL\Tools\DsnParser;
23-
use Doctrine\ORM\ORMSetup;
2423
use Symfony\Component\Lock\Exception\InvalidArgumentException;
2524
use Symfony\Component\Lock\Exception\InvalidTtlException;
2625
use Symfony\Component\Lock\Exception\LockConflictedException;
@@ -88,7 +87,7 @@ public function __construct(Connection|string $connOrUrl, array $options = [], f
8887
$params = ['url' => $connOrUrl];
8988
}
9089

91-
$config = class_exists(ORMSetup::class) ? ORMSetup::createConfiguration() : new Configuration();
90+
$config = new Configuration();
9291
if (class_exists(DefaultSchemaManagerFactory::class)) {
9392
$config->setSchemaManagerFactory(new DefaultSchemaManagerFactory());
9493
}

Tests/Store/DoctrineDbalPostgreSqlStoreTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
use Doctrine\DBAL\Exception as DBALException;
1818
use Doctrine\DBAL\Schema\DefaultSchemaManagerFactory;
1919
use Doctrine\DBAL\Tools\DsnParser;
20-
use Doctrine\ORM\ORMSetup;
2120
use Symfony\Component\Lock\Exception\InvalidArgumentException;
2221
use Symfony\Component\Lock\Exception\LockConflictedException;
2322
use Symfony\Component\Lock\Key;
@@ -173,7 +172,7 @@ public function testWaitAndSaveReadAfterConflictReleasesLockFromInternalStore()
173172
private static function getDbalConnection(string $dsn): Connection
174173
{
175174
$params = class_exists(DsnParser::class) ? (new DsnParser(['sqlite' => 'pdo_sqlite']))->parse($dsn) : ['url' => $dsn];
176-
$config = class_exists(ORMSetup::class) ? ORMSetup::createConfiguration(true) : new Configuration();
175+
$config = new Configuration();
177176
if (class_exists(DefaultSchemaManagerFactory::class)) {
178177
$config->setSchemaManagerFactory(new DefaultSchemaManagerFactory());
179178
}

Tests/Store/DoctrineDbalStoreTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
use Doctrine\DBAL\Exception\TableNotFoundException;
1818
use Doctrine\DBAL\Platforms\AbstractPlatform;
1919
use Doctrine\DBAL\Schema\DefaultSchemaManagerFactory;
20-
use Doctrine\ORM\ORMSetup;
2120
use Symfony\Component\Lock\Key;
2221
use Symfony\Component\Lock\PersistingStoreInterface;
2322
use Symfony\Component\Lock\Store\DoctrineDbalStore;
@@ -39,7 +38,7 @@ public static function setUpBeforeClass(): void
3938
{
4039
self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_lock');
4140

42-
$config = class_exists(ORMSetup::class) ? ORMSetup::createConfiguration(true) : new Configuration();
41+
$config = new Configuration();
4342
if (class_exists(DefaultSchemaManagerFactory::class)) {
4443
$config->setSchemaManagerFactory(new DefaultSchemaManagerFactory());
4544
}
@@ -60,7 +59,7 @@ protected function getClockDelay()
6059

6160
public function getStore(): PersistingStoreInterface
6261
{
63-
$config = class_exists(ORMSetup::class) ? ORMSetup::createConfiguration(true) : new Configuration();
62+
$config = new Configuration();
6463
if (class_exists(DefaultSchemaManagerFactory::class)) {
6564
$config->setSchemaManagerFactory(new DefaultSchemaManagerFactory());
6665
}

0 commit comments

Comments
 (0)